]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
riscv: kvm: return SBI_ERR_FAILURE for pmu_snapshot_set_shmem() when OOM
authorOsama Abdelkader <osama.abdelkader@gmail.com>
Thu, 14 May 2026 17:36:40 +0000 (19:36 +0200)
committerAnup Patel <anup@brainfault.org>
Mon, 18 May 2026 04:49:18 +0000 (10:19 +0530)
kvm_riscv_vcpu_pmu_snapshot_set_shmem() returned -ENOMEM from the
SBI extension handler, which caused kvm_riscv_vcpu_sbi_ecall() to
abort KVM_RUN and surface the error to userspace instead of
ompleting the ECALL with a negative SBI error in a0.
Use SBI_ERR_FAILURE and the normal retdata path, matching other PMU
handlers and kvm_sbi_ext_pmu_handler comment.

Fixes: c2f41ddbcdd7 ("RISC-V: KVM: Implement SBI PMU Snapshot feature")
Cc: stable@vger.kernel.org
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20260514173642.41448-1-osama.abdelkader@gmail.com
Signed-off-by: Anup Patel <anup@brainfault.org>
arch/riscv/kvm/vcpu_pmu.c

index a935ed96bc176a7eb4279681f6090418db604750..91aa0155a420da5745aafc3ba33e3282f4760116 100644 (file)
@@ -453,8 +453,10 @@ int kvm_riscv_vcpu_pmu_snapshot_set_shmem(struct kvm_vcpu *vcpu, unsigned long s
        }
 
        kvpmu->sdata = kzalloc(snapshot_area_size, GFP_ATOMIC);
-       if (!kvpmu->sdata)
-               return -ENOMEM;
+       if (!kvpmu->sdata) {
+               sbiret = SBI_ERR_FAILURE;
+               goto out;
+       }
 
        /* No need to check writable slot explicitly as kvm_vcpu_write_guest does it internally */
        if (kvm_vcpu_write_guest(vcpu, saddr, kvpmu->sdata, snapshot_area_size)) {