]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ACPI: video: Reduce the number of auxiliary device dereferences
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 21 May 2026 14:08:16 +0000 (16:08 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 25 May 2026 14:43:52 +0000 (16:43 +0200)
Store the &aux_dev->dev pointer in a separate local variable in
acpi_video_bus_probe() to avoid dereferencing aux_dev many times.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2707186.Lt9SDvczpP@rafael.j.wysocki
drivers/acpi/acpi_video.c

index 05793ddef7875f6ecc0bd6253a8d8338565d57a2..bdc3f4933abf24f0a424616caaec13e7737e6ccb 100644 (file)
@@ -1978,7 +1978,8 @@ static bool acpi_video_bus_dev_is_duplicate(struct device *dev)
 static int acpi_video_bus_probe(struct auxiliary_device *aux_dev,
                                const struct auxiliary_device_id *id_unused)
 {
-       struct acpi_device *device = ACPI_COMPANION(&aux_dev->dev);
+       struct device *dev = &aux_dev->dev;
+       struct acpi_device *device = ACPI_COMPANION(dev);
        static DEFINE_MUTEX(probe_lock);
        struct acpi_video_bus *video;
        static int instance;
@@ -1988,7 +1989,7 @@ static int acpi_video_bus_probe(struct auxiliary_device *aux_dev,
        /* Probe one video bus device at a time in case there are duplicates. */
        guard(mutex)(&probe_lock);
 
-       if (!allow_duplicates && acpi_video_bus_dev_is_duplicate(&aux_dev->dev)) {
+       if (!allow_duplicates && acpi_video_bus_dev_is_duplicate(dev)) {
                pr_info(FW_BUG
                        "Duplicate ACPI video bus devices for the"
                        " same VGA controller, please try module "
@@ -2059,7 +2060,7 @@ static int acpi_video_bus_probe(struct auxiliary_device *aux_dev,
            !auto_detect)
                acpi_video_bus_register_backlight(video);
 
-       error = acpi_video_bus_add_notify_handler(video, &aux_dev->dev);
+       error = acpi_video_bus_add_notify_handler(video, dev);
        if (error)
                goto err_del;