]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainGetStatsCpuProc: Don't fetch stats for inactive VMs
authorPeter Krempa <pkrempa@redhat.com>
Wed, 29 Apr 2026 09:27:17 +0000 (11:27 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 5 May 2026 05:32:11 +0000 (07:32 +0200)
CPU stats for inactive VM make no sense. In this case it's especially
misleading because 'vm->pid' of an inactive VM is '0' so
virProcessGetStat returns stats for virtqemud itself.

Fixes: 044b8744d65f8571038f85685b3c4b241162977b
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index d227ac58cdb4780687f54c013c6f2de8e51b5e21..529e9fe3bec1928091cd30f0215148eba7e87b15 100644 (file)
@@ -17156,6 +17156,9 @@ qemuDomainGetStatsCpuProc(virDomainObj *vm,
     unsigned long long userTime = 0;
     unsigned long long sysTime = 0;
 
+    if (!virDomainObjIsActive(vm))
+        return;
+
     if (virProcessGetStatInfo(&cpuTime, &userTime, &sysTime,
                               NULL, NULL, vm->pid, 0) < 0) {
         /* ignore error */