Fix rwlock type mismatch in delete_ds() error path

The lock is acquired for reading but the error path from
dns_rdata_fromstruct() incorrectly unlocks it as a write lock.

(cherry picked from commit 96a22451d766e1c4d3ec4882d55e598417e4e796)

diff --git a/lib/dns/keytable.c b/lib/dns/keytable.c
index 159740aa746f1ccc4b2166fab664e76b29fac0c8..b8a2e102954a4934a3d5c45586e809248c563e67 100644 (file)
--- a/lib/dns/keytable.c
+++ b/lib/dns/keytable.c
@@ -247,7 +247,7 @@ delete_ds(dns_qp_t *qp, dns_keytable_t *keytable, dns_keynode_t *knode,
        result = dns_rdata_fromstruct(&dsrdata, dns_rdataclass_in,
                                      dns_rdatatype_ds, ds, &b);
        if (result != ISC_R_SUCCESS) {
-               RWUNLOCK(&knode->rwlock, isc_rwlocktype_write);
+               RWUNLOCK(&knode->rwlock, isc_rwlocktype_read);
                return result;
        }