]> git.ipfire.org Git - thirdparty/libnftnl.git/commitdiff
expr: log: release prefix
authorPablo Neira Ayuso <pablo@netfilter.org>
Mon, 18 Nov 2013 13:18:04 +0000 (14:18 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 18 Nov 2013 13:18:04 +0000 (14:18 +0100)
Ana Rey reported a leak in the log expression. Fix it by using
the new .free interface added in (3cf788a expr: fix leak in target
and match expressions).

Reported-by: Ana Rey Botello <anarey@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/expr/log.c

index 1f88246c5a94f1a0175ec291ef23a5eddc72dff0..2d3e0cf7f4f377acd12d2d0a5af8b8389dbcf09a 100644 (file)
@@ -268,10 +268,18 @@ nft_rule_expr_log_snprintf(char *buf, size_t len, uint32_t type,
        return -1;
 }
 
+static void nft_rule_expr_log_free(struct nft_rule_expr *e)
+{
+       struct nft_expr_log *log = nft_expr_data(e);
+
+       xfree(log->prefix);
+}
+
 struct expr_ops expr_ops_log = {
        .name           = "log",
        .alloc_len      = sizeof(struct nft_expr_log),
        .max_attr       = NFTA_LOG_MAX,
+       .free           = nft_rule_expr_log_free,
        .set            = nft_rule_expr_log_set,
        .get            = nft_rule_expr_log_get,
        .parse          = nft_rule_expr_log_parse,