BUG/MINOR: ssl: fix memory leaks on realloc failure in ssl_ckch.c

Replace bare realloc() calls with my_realloc2(), which frees the original
pointer on allocation failure, preventing a memory leak when the pointer
is subsequently overwritten with NULL.

Must be backported to 3.2.

diff --git a/src/ssl_ckch.c b/src/ssl_ckch.c
index 122d314e6e12e250f813d197198a375ebfdc0fe6..75392a6c2cc895c5eb0058af89ca58879b224abd 100644 (file)
--- a/src/ssl_ckch.c
+++ b/src/ssl_ckch.c
@@ -1098,7 +1098,7 @@ struct ckch_store *ckchs_dup(const struct ckch_store *src)
                /* copy the array of domain strings */
 
                while (src->conf.acme.domains[n]) {
-                       r = realloc(r, sizeof(char *) * (n + 2));
+                       r = my_realloc2(r, sizeof(char *) * (n + 2));
                        if (!r)
                                goto error;
 
@@ -5197,7 +5197,7 @@ int ckch_conf_parse(char **args, int cur_arg, struct ckch_conf *f, int *found, c
                                do {
                                        while (*e != ',' && *e != '\0')
                                                e++;
-                                       r = realloc(r, sizeof(char *) * (n + 2));
+                                       r = my_realloc2(r, sizeof(char *) * (n + 2));
                                        if (!r) {
                                                ha_alert("parsing [%s:%d]: out of memory.\n", file, linenum);
                                                err_code |= ERR_ALERT | ERR_ABORT;