]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
daemon: fix clang warnings
authorGrigorii Demidov <grigorii.demidov@nic.cz>
Tue, 9 Jan 2018 09:35:26 +0000 (10:35 +0100)
committerGrigorii Demidov <grigorii.demidov@nic.cz>
Tue, 9 Jan 2018 09:35:26 +0000 (10:35 +0100)
daemon/io.c
daemon/worker.c

index 0cfe5b3c5de4b2d92053fb0b93ef2700c8814fe4..d8a6efb9e1b701fb90ca2dd76d6765e3794320e6 100644 (file)
@@ -108,16 +108,6 @@ static void session_release(struct worker_ctx *worker, uv_handle_t *handle)
        }
 }
 
-static uv_stream_t *handle_alloc(uv_loop_t *loop)
-{
-       uv_stream_t *handle = calloc(1, sizeof(uv_handles_t));
-       if (!handle) {
-               return NULL;
-       }
-
-       return handle;
-}
-
 static uv_stream_t *handle_borrow(uv_loop_t *loop)
 {
        struct worker_ctx *worker = loop->data;
@@ -219,7 +209,6 @@ int udp_bindfd(uv_udp_t *handle, int fd)
 static void tcp_timeout_trigger(uv_timer_t *timer)
 {
        struct session *session = timer->data;
-       struct worker_ctx *worker = timer->loop->data;
 
        assert(session->outgoing == false);
        if (session->tasks.len > 0) {
@@ -438,7 +427,6 @@ void io_deinit(uv_handle_t *handle)
        if (!handle) {
                return;
        }
-       struct session *session = handle->data;
        uv_loop_t *loop = handle->loop;
        if (loop && loop->data) {
                struct worker_ctx *worker = loop->data;
index 522e5803b66f76e1367e301bc7f298b24bf96f6b..0569d3b61a8ec2ac530e15104e37557f08083480 100644 (file)
@@ -149,10 +149,9 @@ static inline void iohandle_release(struct worker_ctx *worker, void *h)
 {
        assert(h);
 
-       const size_t size = sizeof(uv_handles_t);
        if (worker->pool_iohandles.len < MP_FREELIST_SIZE) {
                array_push(worker->pool_iohandles, h);
-               kr_asan_poison(h, size);
+               kr_asan_poison(h, sizeof(uv_handles_t));
        } else {
                free(h);
        }
@@ -188,10 +187,9 @@ static inline void iorequest_release(struct worker_ctx *worker, void *r)
 {
        assert(r);
 
-       const size_t size = sizeof(uv_reqs_t);
        if (worker->pool_ioreqs.len < MP_FREELIST_SIZE) {
                array_push(worker->pool_ioreqs, r);
-               kr_asan_poison(r, size);
+               kr_asan_poison(r, sizeof(uv_reqs_t));
        } else {
                free(r);
        }
@@ -1344,7 +1342,6 @@ static void subreq_finalize(struct qr_task *task, const struct sockaddr *packet_
                        qry->secret = leader_qry->secret;
                        leader_qry->secret = 0; /* Next will be already decoded */
                }
-               struct session *follower_source_session = follower->ctx->source.session;
                qr_task_step(follower, packet_source, pkt);
                qr_task_unref(follower);
        }