]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.13] gh-148222: Fix NULL dereference bugs in genericaliasobject.c (GH-148226) ...
authorPrakash Sellathurai <prakashsellathurai@gmail.com>
Sat, 18 Apr 2026 14:54:21 +0000 (20:24 +0530)
committerGitHub <noreply@github.com>
Sat, 18 Apr 2026 14:54:21 +0000 (07:54 -0700)
(cherry picked from commit 634568d030f18183212c01bd4544aa7f97e05442)

Misc/NEWS.d/next/Core_and_Builtins/2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst [new file with mode: 0644]
Objects/genericaliasobject.c

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst
new file mode 100644 (file)
index 0000000..2c273fc
--- /dev/null
@@ -0,0 +1 @@
+Fix vectorcall support in :class:`types.GenericAlias` when the underlying type does not support the vectorcall protocol. Fix possible leaks in :class:`types.GenericAlias` and :class:`types.UnionType` in case of memory error.
index 8e59b3884cf529325bcf7ed5313b85eccb93a1b0..30759ca0e0eb67432d682ed0ff1a3851513fefe8 100644 (file)
@@ -278,7 +278,6 @@ _Py_make_parameters(PyObject *args)
                     len += needed;
                     if (_PyTuple_Resize(&parameters, len) < 0) {
                         Py_DECREF(subparams);
-                        Py_DECREF(parameters);
                         return NULL;
                     }
                 }
@@ -636,7 +635,7 @@ ga_vectorcall(PyObject *self, PyObject *const *args,
               size_t nargsf, PyObject *kwnames)
 {
     gaobject *alias = (gaobject *) self;
-    PyObject *obj = PyVectorcall_Function(alias->origin)(alias->origin, args, nargsf, kwnames);
+    PyObject *obj = PyObject_Vectorcall(alias->origin, args, nargsf, kwnames);
     return set_orig_class(obj, self);
 }