]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
authorRitesh Kumar <quic_riteshk@quicinc.com>
Wed, 28 Jan 2026 11:48:49 +0000 (17:18 +0530)
committerVinod Koul <vkoul@kernel.org>
Sun, 10 May 2026 11:29:37 +0000 (16:59 +0530)
The initial sa8775p eDP PHY binding contribution missed adding support for
voting on the eDP reference clock. This went unnoticed because the UFS PHY
driver happened to enable the same clock.

After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor phy_power_on/off
calls"), the eDP reference clock is no longer kept enabled, which results
in the following PHY power-on failure:

phy phy-aec2a00.phy.10: phy poweron failed --> -110

To fix this, explicit voting for the eDP reference clock is required.
This patch adds the eDP reference clock for sa8775p eDP PHY and updates
the corresponding example node.

Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20260128114853.2543416-2-quic_riteshk@quicinc.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml

index e2730a2f25cfb0496f47ad9f3f9cbf69b1d4649f..6c827cf9692b99293bcac43502fae94bd9353e5c 100644 (file)
@@ -200,9 +200,11 @@ examples:
                   <0x0aec2000 0x1c8>;
 
             clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
-                     <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
+                     <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+                     <&gcc GCC_EDP_REF_CLKREF_EN>;
             clock-names = "aux",
-                          "cfg_ahb";
+                          "cfg_ahb",
+                          "ref";
 
             #clock-cells = <1>;
             #phy-cells = <0>;
index 4a1daae3d8d47ca5f08d97a1864cfd615dcf108d..0bf8bf4f66acfd5fadae21f0f3dd650e85aac625 100644 (file)
@@ -74,6 +74,7 @@ allOf:
         compatible:
           enum:
             - qcom,glymur-dp-phy
+            - qcom,sa8775p-edp-phy
             - qcom,x1e80100-dp-phy
     then:
       properties: