]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.14] Un-skip previously-broken `test_get_type_hints_modules_forward_ref` (#149053)
authorThomas Kowalski <thom.kowa@gmail.com>
Mon, 27 Apr 2026 16:54:56 +0000 (18:54 +0200)
committerGitHub <noreply@github.com>
Mon, 27 Apr 2026 16:54:56 +0000 (09:54 -0700)
Lib/test/test_typing.py

index b30e30d1751ed7d638a5666af560c960787fe368..2c6a5c7466032d9689311c59c97716185de56b47 100644 (file)
@@ -13,7 +13,7 @@ import os
 import pickle
 import re
 import sys
-from unittest import TestCase, main, skip
+from unittest import TestCase, main
 from unittest.mock import patch
 from copy import copy, deepcopy
 
@@ -6686,11 +6686,7 @@ class GetTypeHintsTests(BaseTestCase):
         self.assertEqual(gth(ann_module2), {})
         self.assertEqual(gth(ann_module3), {})
 
-    @skip("known bug")
     def test_get_type_hints_modules_forwardref(self):
-        # FIXME: This currently exposes a bug in typing. Cached forward references
-        # don't account for the case where there are multiple types of the same
-        # name coming from different modules in the same program.
         mgc_hints = {'default_a': Optional[mod_generics_cache.A],
                      'default_b': Optional[mod_generics_cache.B]}
         self.assertEqual(gth(mod_generics_cache), mgc_hints)