]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Remove unnecessary REQUIRE in dns_resolver_attach
authorMark Andrews <marka@isc.org>
Tue, 20 Jun 2023 01:31:55 +0000 (11:31 +1000)
committerMark Andrews <marka@isc.org>
Tue, 27 Jun 2023 05:19:56 +0000 (05:19 +0000)
There is no harm in aquiring an additional reference to the resolver
after it has started shutting down.  All the REQUIRE was doing was
introducing a point of failure when shutting down the server.

lib/dns/resolver.c

index f2c2e1caceb6691348819b5ebcb3f62a2291f521..b5a78ab52b4ccfd724539a0a82305f628fd52e5b 100644 (file)
@@ -10616,7 +10616,6 @@ dns_resolver_attach(dns_resolver_t *source, dns_resolver_t **targetp) {
 
        RRTRACE(source, "attach");
 
-       REQUIRE(!atomic_load_acquire(&source->exiting));
        isc_refcount_increment(&source->references);
 
        *targetp = source;