]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: codecs: fs210x: fix possible buffer overflow
authorAlexander A. Klimov <grandmaster@al2klimov.de>
Wed, 13 May 2026 19:08:52 +0000 (21:08 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 15 May 2026 02:14:55 +0000 (11:14 +0900)
In fs210x_effect_scene_info(), a string was copied like this:

    strscpy(DST, SRC, strlen(SRC) + 1);

A buffer overflow would happen if strlen(SRC) >= sizeof(DST).
Actually, strscpy() must be used this way:

    strscpy(DST, SRC, sizeof(DST));
    strscpy(DST, SRC); // defaults to sizeof(DST)

Fixes: 756117701779 ("ASoC: codecs: Add FourSemi FS2104/5S audio amplifier driver")
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
Link: https://patch.msgid.link/20260513190852.196723-2-grandmaster@al2klimov.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/fs210x.c

index e6195b71adadcc7b40065e3cc711b469e5e9bcad..eda716f817b58cf7a1bc31cddcc8b5a1fd9e53a9 100644 (file)
@@ -968,7 +968,7 @@ static int fs210x_effect_scene_info(struct snd_kcontrol *kcontrol,
        if (scene->name)
                name = scene->name;
 
-       strscpy(uinfo->value.enumerated.name, name, strlen(name) + 1);
+       strscpy(uinfo->value.enumerated.name, name);
 
        return 0;
 }