]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
[master] Remove non-portable isc_buffer_printf() unit test
authorMichał Kępień <michal@isc.org>
Wed, 11 Oct 2017 07:28:44 +0000 (09:28 +0200)
committerMichał Kępień <michal@isc.org>
Wed, 11 Oct 2017 07:30:48 +0000 (09:30 +0200)
lib/isc/tests/buffer_test.c

index ffb2c5fdb80a946483293b99945e3bd4dc507b13..054e7fddc0ee0da981b9635ba0008fa6464eea5c 100644 (file)
@@ -196,8 +196,8 @@ ATF_TC_HEAD(isc_buffer_printf, tc) {
 }
 
 ATF_TC_BODY(isc_buffer_printf, tc) {
-       const char *bad_fmt, *empty_fmt;
        unsigned int used, prev_used;
+       const char *empty_fmt;
        isc_result_t result;
        isc_buffer_t *b, sb;
        char buf[8];
@@ -270,16 +270,6 @@ ATF_TC_BODY(isc_buffer_printf, tc) {
        used = isc_buffer_usedlength(b);
        ATF_CHECK_EQ(prev_used, used);
 
-       /*
-        * Ensure vsnprintf() errors do not cause the buffer to be modified.
-        */
-       prev_used = used;
-       bad_fmt = "%";
-       result = isc_buffer_printf(b, bad_fmt, NULL);
-       ATF_CHECK_EQ(result, ISC_R_FAILURE);
-       used = isc_buffer_usedlength(b);
-       ATF_CHECK_EQ(prev_used, used);
-
        isc_buffer_free(&b);
 
        /*