]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: iwlwifi: mvm: don't support the reset handshake for old firmwares
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Fri, 29 May 2026 05:57:05 +0000 (08:57 +0300)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Sat, 30 May 2026 20:54:42 +0000 (23:54 +0300)
-77.ucode doesn't contain the fixes for this flow it seems.
Don't use the firmware reset handshake even if the firmware claims
support for it.

Fixes: 906d4eb84408 ("iwlwifi: support firmware reset handshake")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220600
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20260529085453.9307b81d9b02.I21bba9e649f4cd0e35d3ea6cd97a03258be5832f@changeid
drivers/net/wireless/intel/iwlwifi/mvm/ops.c

index ae177477b2012716aa1ebc39d35583634e7cb188..384bed95835d74360afb37d781e45e806a545f2d 100644 (file)
@@ -1416,6 +1416,12 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_rf_cfg *cfg,
                fw_has_capa(&mvm->fw->ucode_capa,
                            IWL_UCODE_TLV_CAPA_FW_RESET_HANDSHAKE);
 
+       /* Those firmware versions claim to support the fw_reset_handshake
+        * but they are buggy.
+        */
+       if (IWL_UCODE_MAJOR(mvm->fw->ucode_ver) <= 77)
+               trans->conf.fw_reset_handshake = false;
+
        trans->conf.queue_alloc_cmd_ver =
                iwl_fw_lookup_cmd_ver(mvm->fw,
                                      WIDE_ID(DATA_PATH_GROUP,