]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
add INSISTs to silence tainted data false positive in Coverity
authorMark Andrews <marka@isc.org>
Thu, 12 Jun 2014 00:42:39 +0000 (10:42 +1000)
committerMark Andrews <marka@isc.org>
Thu, 12 Jun 2014 00:46:24 +0000 (10:46 +1000)
(cherry picked from commit 8a2ff13c3dbf43c3a3f0ff8f24d9559ec2d72089)

lib/dns/rdata/generic/tkey_249.c

index 6f1ec0253881103d02cf68ec75d93d3af1cf7e02..09175615f639d9613a97c6738b1a8850c31706e1 100644 (file)
@@ -465,6 +465,7 @@ tostruct_tkey(ARGS_TOSTRUCT) {
        /*
         * Key.
         */
+       INSIST(tkey->keylen + 2 <= sr.length);
        tkey->key = mem_maybedup(mctx, sr.base, tkey->keylen);
        if (tkey->key == NULL)
                goto cleanup;
@@ -479,6 +480,7 @@ tostruct_tkey(ARGS_TOSTRUCT) {
        /*
         * Other.
         */
+       INSIST(tkey->otherlen <= sr.length);
        tkey->other = mem_maybedup(mctx, sr.base, tkey->otherlen);
        if (tkey->other == NULL)
                goto cleanup;