]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
KVM: arm64: Fix meta-page unsharing in pKVM hyp tracing
authorVincent Donnefort <vdonnefort@google.com>
Thu, 21 May 2026 12:46:11 +0000 (13:46 +0100)
committerMarc Zyngier <maz@kernel.org>
Wed, 27 May 2026 13:07:24 +0000 (14:07 +0100)
As the hyp_trace_buffer_unshare_hyp() function name suggests we should
unshare all the previously shared pages, otherwise we leak hyp-shared
pages which won't be reusable for hyp memory.

Fix the typo by calling __unshare_page() on the meta-page, ensuring all
previously shared pages are correctly unshared.

Fixes: 3aed038aac8d ("KVM: arm64: Add trace remote for the nVHE/pKVM hyp")
Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
Link: https://patch.msgid.link/20260521124613.911067-2-vdonnefort@google.com
Signed-off-by: Marc Zyngier <maz@kernel.org>
arch/arm64/kvm/hyp_trace.c

index 8b7f2bf2fba84dce85b56f5d88e3104f5d672cbd..06805b4261015ae88bf61de3362771572b000494 100644 (file)
@@ -189,7 +189,7 @@ static void hyp_trace_buffer_unshare_hyp(struct hyp_trace_buffer *trace_buffer,
                if (cpu > last_cpu)
                        break;
 
-               __share_page(rb_desc->meta_va);
+               __unshare_page(rb_desc->meta_va);
                for (p = 0; p < rb_desc->nr_page_va; p++)
                        __unshare_page(rb_desc->page_va[p]);
        }