]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Clear errno before calling strtol
authorMark Andrews <marka@isc.org>
Wed, 4 Mar 2026 06:51:09 +0000 (17:51 +1100)
committerMark Andrews (GitLab job 7040088) <marka@isc.org>
Tue, 17 Mar 2026 00:28:07 +0000 (00:28 +0000)
The previous code was incorrectly clearing errno after calling
strtol but before testing the result rather than clearing it and
then calling strtol so that changes to errno can be correctly
determined.

(cherry picked from commit d3ffa1f0073899a96e478906fff5af31eba33784)

lib/isc/httpd.c

index 18fecf1c6e8c1b365cc6011ad1308fff5ee6add5..809cb30728320f8b9acc92374d71589c415df73a 100644 (file)
@@ -425,9 +425,8 @@ process_request(isc_httpd_t *httpd, size_t last_len) {
 
                if (name_match(header, "Content-Length")) {
                        char *endptr;
-                       long val = strtol(header->value, &endptr, 10);
-
                        errno = 0;
+                       long val = strtol(header->value, &endptr, 10);
 
                        /* ensure we consumed all digits */
                        if ((header->value + header->value_len) != endptr) {