Some more of Lee's warning cleanup, being explicit with assignment brackets.

diff --git a/util/faxconfig.c b/util/faxconfig.c
index 26c8570ba776d2f9b55922efd38e6ebb8ba5a193..c15773198d10c4e7625d93158c35e7175ad7d362 100644 (file)
--- a/util/faxconfig.c
+++ b/util/faxconfig.c
@@ -93,7 +93,7 @@ main(int argc, char** argv)
     } else {
         strcpy(fifoname, FAX_FIFO);
     }
-    for (cp = fifoname; cp = strchr(cp, '/'); *cp++ = '_')
+    for (cp = fifoname; (cp = strchr(cp, '/')); *cp++ = '_')
        ;
     if (chdir(spooldir) < 0)
        fatal("%s: chdir: %s", spooldir, strerror(errno));

diff --git a/util/faxmodem.c b/util/faxmodem.c
index 45beac1e78f1e38c468e75f04de6ab8bb273708d..9bbcc57f48baffaa4703f6f116f5574c672aae2b 100644 (file)
--- a/util/faxmodem.c
+++ b/util/faxmodem.c
@@ -217,7 +217,7 @@ parseCapabilities(const char* cp, u_int* caps)
             | ((ln&LN_ALL)<<19)
             | ((df&DF_ALL)<<22)
             | ((ec&EC_DISABLE)<<26)
-            | ((ec&EC_ALL != 0 ? 1 : 0)<<27)
+            | (((ec&EC_ALL) != 0 ? 1 : 0)<<27)
             | ((bf&BF_ALL)<<28)
             | ((st&ST_ALL)<<30)
             ;
@@ -301,7 +301,7 @@ main(int argc, char** argv)
             fatal("Argument is too long: %s", argv[optind]);
         }
     }
-    for (cp = devname; cp = strchr(cp, '/'); *cp++ = '_')
+    for (cp = devname; (cp = strchr(cp, '/')); *cp++ = '_')
        ;
     if (chdir(spooldir) < 0) {
         fatal("%s: chdir: %s", spooldir, strerror(errno));

diff --git a/util/faxstate.c b/util/faxstate.c
index c57c5976bdcc68691c9d5b62a7061262767b0386..6756d27f3d6889ce37cca4c404739805e10c55a7 100644 (file)
--- a/util/faxstate.c
+++ b/util/faxstate.c
@@ -121,7 +121,7 @@ main(int argc, char** argv)
     } else {
         fatal("Argument is too large: %s", argv[optind]);
     }
-    for (cp = devid; cp = strchr(cp, '/'); *cp++ = '_')
+    for (cp = devid; (cp = strchr(cp, '/')); *cp++ = '_')
        ;
     if (chdir(spooldir) < 0)
        fatal("%s: chdir: %s", spooldir, strerror(errno));