]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: max9286: normalize return value of gpio_get
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Feb 2026 20:53:48 +0000 (12:53 -0800)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 11 Mar 2026 00:05:35 +0000 (01:05 +0100)
The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by max9286_gpiochip_get() is
normalized to the [0, 1] range.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/max9286.c

index e6e214f8294b83105be02f29966e1d3ed72f8dbe..ac0712ce1e6585e4567cc00c354a40e15a62b269 100644 (file)
@@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
 {
        struct max9286_priv *priv = gpiochip_get_data(chip);
 
-       return priv->gpio_state & BIT(offset);
+       return !!(priv->gpio_state & BIT(offset));
 }
 
 static int max9286_register_gpio(struct max9286_priv *priv)