GDB: testsuite: server: Don't return -1 from top-level (sed)

This patch is purely the result of running:

$ sed -i 's/^    return -1/    return/' *.exp*

inside gdb/testsuite/gdb.server.

Approved-By: Tom Tromey <tom@tromey.com>

diff --git a/gdb/testsuite/gdb.server/build-id-seqno.exp b/gdb/testsuite/gdb.server/build-id-seqno.exp
index 44bdb09b60ad574048a8f541088db7cb8d8752a0..1fa27e80aa0f5d2ec933ec04155f2dce651a72c0 100644 (file)
--- a/gdb/testsuite/gdb.server/build-id-seqno.exp
+++ b/gdb/testsuite/gdb.server/build-id-seqno.exp
@@ -36,12 +36,12 @@ require allow_gdbserver_tests
 standard_testfile
 
 if {[build_executable "failed to prepare" $testfile $srcfile] == -1} {
-    return -1
+    return
 }
 
 # Split out BINFILE.debug.  Remove debug from BINFILE.
 if {[gdb_gnu_strip_debug $binfile] != 0} {
-    return -1
+    return
 }
 
 # Get the '.build-id/xx/xxx...xxx' part of the filename.

diff --git a/gdb/testsuite/gdb.server/connect-stopped-target.exp b/gdb/testsuite/gdb.server/connect-stopped-target.exp
index cfe38fcbfc6a4438532090f08b862c48a728f135..74ccd774561e11f4b528e7360f54ec2094a7f33f 100644 (file)
--- a/gdb/testsuite/gdb.server/connect-stopped-target.exp
+++ b/gdb/testsuite/gdb.server/connect-stopped-target.exp
@@ -26,7 +26,7 @@ standard_testfile
 set executable ${testfile}
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 proc do_test {nonstop} {

diff --git a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
index fcdc6978d6183a3cc514d24be129ffa2455bfcb9..7e2b33e09a9874efa156620c6b84c166e407a441 100644 (file)
--- a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
+++ b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
@@ -28,7 +28,7 @@ standard_testfile
 require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" $testfile $srcfile debug] } {
-    return -1
+    return
 }
 
 # Test connecting GDB to GDBserver without loading a symbol file.

diff --git a/gdb/testsuite/gdb.server/connect-without-multi-process.exp b/gdb/testsuite/gdb.server/connect-without-multi-process.exp
index 4b41f461a79db59e0e4a30b49a3f7bb6200e99f2..33787acded5177e974b613967fd7439ef3920854 100644 (file)
--- a/gdb/testsuite/gdb.server/connect-without-multi-process.exp
+++ b/gdb/testsuite/gdb.server/connect-without-multi-process.exp
@@ -23,7 +23,7 @@ require allow_gdbserver_tests
 standard_testfile
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Test spawning gdbserver with a program, connect to it and run to

diff --git a/gdb/testsuite/gdb.server/ext-attach.exp b/gdb/testsuite/gdb.server/ext-attach.exp
index 0dd02c145ac4d8b39f24b0425e784834645f9ce5..cb4c12772289bee76ca4a34966c7a3bda22a7523 100644 (file)
--- a/gdb/testsuite/gdb.server/ext-attach.exp
+++ b/gdb/testsuite/gdb.server/ext-attach.exp
@@ -27,7 +27,7 @@ require allow_gdbserver_tests
 require can_spawn_for_attach
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Run the test.  TARGET_NON_STOP and TARGET_ASYNC should be 'on'

diff --git a/gdb/testsuite/gdb.server/ext-run.exp b/gdb/testsuite/gdb.server/ext-run.exp
index 83de771902b4a428244499ab8ac7708e309d0179..4fb2fe004f269af3bc13cee253db53710431b051 100644 (file)
--- a/gdb/testsuite/gdb.server/ext-run.exp
+++ b/gdb/testsuite/gdb.server/ext-run.exp
@@ -24,7 +24,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
-    return -1
+    return
 }
 
 # allow_xml_test must be called while gdb is not running.

diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.server/ext-wrapper.exp
index 836c32a757456daf098add3481f304d6b6dc7a23..912a8ce377083b964ec2f82806a2fa92426f6117 100644 (file)
--- a/gdb/testsuite/gdb.server/ext-wrapper.exp
+++ b/gdb/testsuite/gdb.server/ext-wrapper.exp
@@ -22,7 +22,7 @@ standard_testfile wrapper.c
 require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {

diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp
index 5fe4ebd5729794f7c0f4eb4c86acfda2ed81a005..f10d2f374c09644c2ab1428e420d2d0a04b981cb 100644 (file)
--- a/gdb/testsuite/gdb.server/extended-remote-restart.exp
+++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp
@@ -48,7 +48,7 @@ if { [info proc gdb_reconnect] == "" } {
 standard_testfile
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Core of the test.  DO_KILL_P controls whether we kill one of the

diff --git a/gdb/testsuite/gdb.server/file-transfer.exp b/gdb/testsuite/gdb.server/file-transfer.exp
index f33c589c961ecf5062ec23f7cf6988beb64acd9f..a4517582b257df5062a23626668127427fb11414 100644 (file)
--- a/gdb/testsuite/gdb.server/file-transfer.exp
+++ b/gdb/testsuite/gdb.server/file-transfer.exp
@@ -23,7 +23,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Make sure we're disconnected, in case we're testing with an

diff --git a/gdb/testsuite/gdb.server/inferior-args.exp b/gdb/testsuite/gdb.server/inferior-args.exp
index 312e756f0d80ff72e86cf0930ce54a03d747e9b1..f6ad3e69b40717134faaf7f0c07dfc1ad6ae10b2 100644 (file)
--- a/gdb/testsuite/gdb.server/inferior-args.exp
+++ b/gdb/testsuite/gdb.server/inferior-args.exp
@@ -35,7 +35,7 @@ if { $gdbserver == "" } {
 
 standard_testfile
 if {[build_executable "failed to prepare" $testfile $srcfile]} {
-    return -1
+    return
 }
 
 # EXTENDED_P is a boolean, when true gdbserver is started with --multi, and

diff --git a/gdb/testsuite/gdb.server/monitor-exit-quit.exp b/gdb/testsuite/gdb.server/monitor-exit-quit.exp
index c5f8426cb5deb986d540d7e4e855b31e2e553934..cb90169ef0cc504108e6356133f30d148d5c0723 100644 (file)
--- a/gdb/testsuite/gdb.server/monitor-exit-quit.exp
+++ b/gdb/testsuite/gdb.server/monitor-exit-quit.exp
@@ -24,7 +24,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {

diff --git a/gdb/testsuite/gdb.server/no-thread-db.exp b/gdb/testsuite/gdb.server/no-thread-db.exp
index e04e43c78a3cbdd14d88948c737b503970307509..9cbe962bc3c0429da2ab4b6f5202a06cd3a0733d 100644 (file)
--- a/gdb/testsuite/gdb.server/no-thread-db.exp
+++ b/gdb/testsuite/gdb.server/no-thread-db.exp
@@ -28,7 +28,7 @@ set unresolvable_thread_db_path "/foo/bar"
 require allow_gdbserver_tests
 
 if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {

diff --git a/gdb/testsuite/gdb.server/pread-offset-size.exp b/gdb/testsuite/gdb.server/pread-offset-size.exp
index 4362878c8e6e3a2c6316ef164696f9b11a90dabe..68f938d42c675ab0df0f16fdd5aea35fd32f2faf 100644 (file)
--- a/gdb/testsuite/gdb.server/pread-offset-size.exp
+++ b/gdb/testsuite/gdb.server/pread-offset-size.exp
@@ -24,7 +24,7 @@ standard_testfile .S
 
 if { [prepare_for_testing ${testfile}.exp $testfile \
        $srcfile {debug additional_flags=-nostdlib} ] } {
-    return -1
+    return
 }
 
 clean_restart

diff --git a/gdb/testsuite/gdb.server/remote-read-msgs.exp b/gdb/testsuite/gdb.server/remote-read-msgs.exp
index 86c2d610c00bd7a17a3fc9d10046936dea1a1031..e9d03388e3987cc0e8ca97e5644985efc704f7fc 100644 (file)
--- a/gdb/testsuite/gdb.server/remote-read-msgs.exp
+++ b/gdb/testsuite/gdb.server/remote-read-msgs.exp
@@ -32,12 +32,12 @@ standard_testfile
 
 if {[build_executable "failed to prepare" $testfile $srcfile \
     {debug build-id}] == -1} {
-    return -1
+    return
 }
 
 # Split out BINFILE.debug.  Remove debug from BINFILE.
 if {[gdb_gnu_strip_debug $binfile] != 0} {
-    return -1
+    return
 }
 
 # Get the '.build-id/xx/xxx...xxx' part of the filename.

diff --git a/gdb/testsuite/gdb.server/run-without-local-binary.exp b/gdb/testsuite/gdb.server/run-without-local-binary.exp
index 3aa9eba2d05d192d0f2628c449eaf51c0214a30c..24521f21b0f9ef1a405ac609a421fa46cc6abf7f 100644 (file)
--- a/gdb/testsuite/gdb.server/run-without-local-binary.exp
+++ b/gdb/testsuite/gdb.server/run-without-local-binary.exp
@@ -20,7 +20,7 @@ require allow_gdbserver_tests
 standard_testfile normal.c
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]

diff --git a/gdb/testsuite/gdb.server/server-connect.exp b/gdb/testsuite/gdb.server/server-connect.exp
index bb6a5758d359929c46f136fbd99648f74f640b35..3c8dd114166afc096c8b4ed381a4f814513b22c4 100644 (file)
--- a/gdb/testsuite/gdb.server/server-connect.exp
+++ b/gdb/testsuite/gdb.server/server-connect.exp
@@ -28,7 +28,7 @@ require allow_gdbserver_tests
 require {!is_remote target}
 
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
-    return -1
+    return
 }
 
 # Make sure we're disconnected, in case we're testing with an

diff --git a/gdb/testsuite/gdb.server/server-exec-info.exp b/gdb/testsuite/gdb.server/server-exec-info.exp
index 7163785348d92f215504ae30c8eafb9c3d6730a9..4ef9ede9cec0ea37f1e0ef4e652087537bba580a 100644 (file)
--- a/gdb/testsuite/gdb.server/server-exec-info.exp
+++ b/gdb/testsuite/gdb.server/server-exec-info.exp
@@ -22,7 +22,7 @@ require allow_gdbserver_tests allow_shlib_tests
 
 standard_testfile server.c
 if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
-    return -1
+    return
 }
 
 # Make sure we're disconnected, in case we're testing with an

diff --git a/gdb/testsuite/gdb.server/server-kill-python.exp b/gdb/testsuite/gdb.server/server-kill-python.exp
index 09e4d561bee9b1a8acf5ef1a55ca7c635849a57a..7c08090c16565036f03de5c8cb28cc78022f2e8f 100644 (file)
--- a/gdb/testsuite/gdb.server/server-kill-python.exp
+++ b/gdb/testsuite/gdb.server/server-kill-python.exp
@@ -27,7 +27,7 @@ require allow_gdbserver_tests allow_python_tests
 
 if {[build_executable "failed to prepare" ${testfile} \
         ${srcfile}] == -1} {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]

diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index 9a92ef2a6c7503e13cbbcef6f04b8a70a84b7f2f..d4bbb466f04cb71f4a38d83eaa8a3fa4e4008f11 100644 (file)
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -25,7 +25,7 @@ standard_testfile
 require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" ${testfile}] } {
-    return -1
+    return
 }
 
 # Spawn GDBserver, run to main, extract GDBserver's PID and save it in

diff --git a/gdb/testsuite/gdb.server/server-mon.exp b/gdb/testsuite/gdb.server/server-mon.exp
index 8811a0c8afa7ef5db0b4b1b15ae990b187d1e7d9..ef054059faf8c0f2b6501fb362167ba0dca4af15 100644 (file)
--- a/gdb/testsuite/gdb.server/server-mon.exp
+++ b/gdb/testsuite/gdb.server/server-mon.exp
@@ -24,7 +24,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Make sure we're disconnected, in case we're testing with an

diff --git a/gdb/testsuite/gdb.server/server-pipe.exp b/gdb/testsuite/gdb.server/server-pipe.exp
index ca9d9cab8b676cc5deb71c69877aebf5992a2ca7..724e5a047b1eae73c2cbbed73ebf65e72fe282a3 100644 (file)
--- a/gdb/testsuite/gdb.server/server-pipe.exp
+++ b/gdb/testsuite/gdb.server/server-pipe.exp
@@ -42,7 +42,7 @@ standard_testfile normal.c
 set executable ${testfile}
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Start GDB using remote type TARGET, which should be either "remote"

diff --git a/gdb/testsuite/gdb.server/server-run.exp b/gdb/testsuite/gdb.server/server-run.exp
index 776851b369555eacca15b87efa1ca7ece7d6c1a6..a20ef0a5a1fc2da9b585d92bc56a0b465bd94ad9 100644 (file)
--- a/gdb/testsuite/gdb.server/server-run.exp
+++ b/gdb/testsuite/gdb.server/server-run.exp
@@ -24,7 +24,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {

diff --git a/gdb/testsuite/gdb.server/solib-list.exp b/gdb/testsuite/gdb.server/solib-list.exp
index ab0fd1586cb177191fa5fc94598dc69338a428c4..c529bb6edd06db4a177e55d62bb4317116c266bd 100644 (file)
--- a/gdb/testsuite/gdb.server/solib-list.exp
+++ b/gdb/testsuite/gdb.server/solib-list.exp
@@ -32,7 +32,7 @@ set binlibfile [standard_output_file ${testfile}.so]
 if { [gdb_compile_shlib "${srcdir}/${subdir}/${srclibfile}" "${binlibfile}" {debug}] != ""
      || [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable "shlib=${binlibfile} build-id"] != "" } {
     untested "failed to compile"
-    return -1
+    return
 }
 
 set interp_system [section_get ${binfile} .interp]

diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
index 01bf3ef67dcaceb64b70c830211bf3a7abac1384..a7eda3f76f062ac19132dbafc2879ed48a852b00 100644 (file)
--- a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
+++ b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
@@ -34,7 +34,7 @@ require allow_gdbserver_tests
 
 standard_testfile
 if { [build_executable "failed to prepare" $testfile $srcfile {debug pthreads}] == -1 } {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]

diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
index fec2246b479163e3a86ff7daa651dcaa485a2d52..700b7022415156709aeccf7a6c37b60ccaea061b 100644 (file)
--- a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
+++ b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
@@ -26,7 +26,7 @@ require allow_gdbserver_tests
 
 standard_testfile
 if { [build_executable "failed to prepare" $testfile $srcfile] == -1 } {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]

diff --git a/gdb/testsuite/gdb.server/sysroot.exp b/gdb/testsuite/gdb.server/sysroot.exp
index 634168db469356c763b2a6d47269e45ebeab9929..7e4a796e8791e384f9c7fe5c8465ccec521261d9 100644 (file)
--- a/gdb/testsuite/gdb.server/sysroot.exp
+++ b/gdb/testsuite/gdb.server/sysroot.exp
@@ -24,7 +24,7 @@ require allow_gdbserver_tests
 
 standard_testfile
 if {[build_executable "failed to prepare" $testfile $srcfile "additional_flags=--no-builtin"] == -1} {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]

diff --git a/gdb/testsuite/gdb.server/target-exec-file.exp b/gdb/testsuite/gdb.server/target-exec-file.exp
index 7c204cc9abdec24ee15fbec4252f1c23ced67466..a9e6f801165d0c18eccfb93eccd5a1a863d6f1e8 100644 (file)
--- a/gdb/testsuite/gdb.server/target-exec-file.exp
+++ b/gdb/testsuite/gdb.server/target-exec-file.exp
@@ -26,7 +26,7 @@ require allow_gdbserver_tests !use_gdb_stub
 standard_testfile
 
 if { [build_executable "failed to prepare" $testfile $srcfile debug] } {
-    return -1
+    return
 }
 
 clean_restart
@@ -223,7 +223,7 @@ set res [remote_exec target "touch $target_exec"]
 set status [lindex $res 0]
 if { $status != 0 } {
     fail "touching executable on target"
-    return -1
+    return
 }
 
 # Start the inferior again, we expect to see the symbols being re-read

diff --git a/gdb/testsuite/gdb.server/twice-connect.exp b/gdb/testsuite/gdb.server/twice-connect.exp
index eaf910179f7fe8e53dce044aa30e5d225d677bb0..45f2eb5aa596cffcb16a2ca13b7b4d70aa95e283 100644 (file)
--- a/gdb/testsuite/gdb.server/twice-connect.exp
+++ b/gdb/testsuite/gdb.server/twice-connect.exp
@@ -23,7 +23,7 @@ require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" $::testfile $::srcfile \
          {debug}] } {
-    return -1
+    return
 }
 
 # Don't use $binfile arg, to make sure we use the remote file target:$binfile.

diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
index 9478640c40e2a92e5e80e2ed1e0a17d859a5fe57..15643fb92a7ca1900918dcb2b47cbf7a4f94dfd8 100644 (file)
--- a/gdb/testsuite/gdb.server/wrapper.exp
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -26,7 +26,7 @@ require allow_gdbserver_tests
 if { [istarget *-*-mingw*]
      || [istarget *-*-cygwin*] } {
     unsupported "gdbserver does not support --wrapper on this target (PR server/15967)"
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {