pullup:

Certain TKEY processing failure modes could
reference an uninitialized variable, causing the
server to crash. [RT #750]

diff --git a/CHANGES b/CHANGES
index 1a50f0d27ecd638c00d1da92b01cba8fb41354f7..ae699b5056213e7f70191fa5df4598c3c6909e7d 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,4 +1,8 @@
 
+ 717.  [bug]           Certain TKEY processing failure modes could
+                       reference an uninitialized variable, causing the
+                       server to crash. [RT #750]
+
  711.  [bug]           The libisc and liblwres implementations of
                        inet_ntop contained an off by one error.
 

diff --git a/lib/dns/tkey.c b/lib/dns/tkey.c
index 434160cb7214ea7d57c2ffbdf64273e7cf211144..cf9c3b719c7d74f46aec701a8850155bd81fb2bf 100644 (file)
--- a/lib/dns/tkey.c
+++ b/lib/dns/tkey.c
@@ -16,7 +16,7 @@
  */
 
 /*
- * $Id: tkey.c,v 1.57.2.4 2001/01/11 20:34:09 gson Exp $
+ * $Id: tkey.c,v 1.57.2.5 2001/01/30 22:12:22 gson Exp $
  */
 
 #include <config.h>
@@ -564,6 +564,8 @@ dns_tkey_processquery(dns_message_t *msg, dns_tkeyctx_t *tctx,
        REQUIRE(tctx != NULL);
        REQUIRE(ring != NULL);
 
+       ISC_LIST_INIT(namelist);
+
        /*
         * Need to do this to determine if this should be freed later.
         */
@@ -634,8 +636,6 @@ dns_tkey_processquery(dns_message_t *msg, dns_tkeyctx_t *tctx,
        } else
                signer = &tsigner;
 
-       ISC_LIST_INIT(namelist);
-
        tkeyout.common.rdclass = tkeyin.common.rdclass;
        tkeyout.common.rdtype = tkeyin.common.rdtype;
        ISC_LINK_INIT(&tkeyout.common, link);