]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:dns_server: Remove less-than-zero comparison of an unsigned value
authorAndreas Schneider <asn@samba.org>
Tue, 14 Dec 2021 14:42:06 +0000 (15:42 +0100)
committerJeremy Allison <jra@samba.org>
Wed, 15 Dec 2021 19:32:30 +0000 (19:32 +0000)
This will never be true. Found by covscan

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/dns_server/pydns.c

index 0b2013c384b4e3a45995ba4b6b2143bc7e0db08b..7b83d7c49a11aa775b22a91a9936e2dc8b364a50 100644 (file)
@@ -388,7 +388,7 @@ static PyObject *py_dsdb_dns_timestamp_to_nt_time(PyObject *self, PyObject *args
                return NULL;
        }
 
-       if (timestamp > UINT32_MAX || timestamp < 0) {
+       if (timestamp > UINT32_MAX) {
                PyErr_SetString(PyExc_ValueError, "Time out of range");
                return NULL;
        }