]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
staging: rtl8723bs: rename CamelCase function Set_MSR to set_msr
authorTan Kai Zhe <kaizhetan@yahoo.com>
Sat, 7 Feb 2026 06:13:13 +0000 (14:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Feb 2026 13:45:39 +0000 (14:45 +0100)
Adhere to Linux kernel coding style.

Reported by checkpatch:

CHECK: Avoid CamelCase: <Set_MSR>

Signed-off-by: Tan Kai Zhe <kaizhetan@yahoo.com>
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Link: https://patch.msgid.link/20260207061313.20103-1-kaizhetan@yahoo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_ap.c
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
drivers/staging/rtl8723bs/core/rtw_wlan_util.c
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h

index 79069055da7a0e5882f1ccb0a9fbd53f0e75be7a..ebe73abab89249fdbd4af0ace6f2933c4df78011 100644 (file)
@@ -687,7 +687,7 @@ void start_bss_network(struct adapter *padapter)
        }
 
        /* set MSR to AP_Mode */
-       Set_MSR(padapter, _HW_STATE_AP_);
+       set_msr(padapter, _HW_STATE_AP_);
 
        /* Set BSSID REG */
        rtw_hal_set_hwreg(padapter, HW_VAR_BSSID, pnetwork->mac_address);
index 5a4fdf0cddd2ded3b44290374e89db7f3b9abfe0..78abc5f5191f231d1d02301fa31479a7141bf4ae 100644 (file)
@@ -3853,7 +3853,7 @@ void site_survey(struct adapter *padapter)
                        /* rtw_hal_set_hwreg(padapter, HW_VAR_TXPAUSE, (u8 *)(&val8)); */
 
                        /* config MSR */
-                       Set_MSR(padapter, (pmlmeinfo->state & 0x3));
+                       set_msr(padapter, (pmlmeinfo->state & 0x3));
 
                        initialgain = 0xff; /* restore RX GAIN */
                        rtw_hal_set_hwreg(padapter, HW_VAR_INITIAL_GAIN, (u8 *)(&initialgain));
@@ -4070,7 +4070,7 @@ void start_create_ibss(struct adapter *padapter)
 
                /* set msr to WIFI_FW_ADHOC_STATE */
                pmlmeinfo->state = WIFI_FW_ADHOC_STATE;
-               Set_MSR(padapter, (pmlmeinfo->state & 0x3));
+               set_msr(padapter, (pmlmeinfo->state & 0x3));
 
                /* issue beacon */
                if (send_beacon(padapter) == _FAIL) {
@@ -4109,7 +4109,7 @@ void start_clnt_join(struct adapter *padapter)
        caps = rtw_get_capability((struct wlan_bssid_ex *)pnetwork);
        update_capinfo(padapter, caps);
        if (caps&WLAN_CAPABILITY_ESS) {
-               Set_MSR(padapter, WIFI_FW_STATION_STATE);
+               set_msr(padapter, WIFI_FW_STATION_STATE);
 
                val8 = (pmlmeinfo->auth_algo == dot11AuthAlgrthm_8021X) ? 0xcc : 0xcf;
 
@@ -4136,7 +4136,7 @@ void start_clnt_join(struct adapter *padapter)
 
                pmlmeinfo->state = WIFI_FW_AUTH_NULL | WIFI_FW_STATION_STATE;
        } else if (caps&WLAN_CAPABILITY_IBSS) { /* adhoc client */
-               Set_MSR(padapter, WIFI_FW_ADHOC_STATE);
+               set_msr(padapter, WIFI_FW_ADHOC_STATE);
 
                val8 = 0xcf;
                rtw_hal_set_hwreg(padapter, HW_VAR_SEC_CFG, (u8 *)(&val8));
@@ -4742,7 +4742,7 @@ static void rtw_mlmeext_disconnect(struct adapter *padapter)
        rtw_hal_set_hwreg(padapter, HW_VAR_BSSID, null_addr);
 
        /* set MSR to no link state -> infra. mode */
-       Set_MSR(padapter, _HW_STATE_STATION_);
+       set_msr(padapter, _HW_STATE_STATION_);
 
        pmlmeinfo->state = WIFI_FW_NULL_STATE;
 
@@ -5185,7 +5185,7 @@ u8 setopmode_hdl(struct adapter *padapter, u8 *pbuf)
        }
 
        rtw_hal_set_hwreg(padapter, HW_VAR_SET_OPMODE, (u8 *)(&type));
-       /* Set_MSR(padapter, type); */
+       /* set_msr(padapter, type); */
 
        if (psetop->mode == Ndis802_11APMode) {
                /*  Do this after port switch to */
@@ -5279,8 +5279,8 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf)
                timer_delete_sync(&pmlmeext->link_timer);
 
                /* set MSR to nolink -> infra. mode */
-               /* Set_MSR(padapter, _HW_STATE_NOLINK_); */
-               Set_MSR(padapter, _HW_STATE_STATION_);
+               /* set_msr(padapter, _HW_STATE_NOLINK_); */
+               set_msr(padapter, _HW_STATE_STATION_);
 
 
                rtw_hal_set_hwreg(padapter, HW_VAR_MLME_DISCONNECT, NULL);
@@ -5543,7 +5543,7 @@ u8 sitesurvey_cmd_hdl(struct adapter *padapter, u8 *pbuf)
                rtw_hal_set_hwreg(padapter, HW_VAR_INITIAL_GAIN, (u8 *)(&initialgain));
 
                /* set MSR to no link state */
-               Set_MSR(padapter, _HW_STATE_NOLINK_);
+               set_msr(padapter, _HW_STATE_NOLINK_);
 
                val8 = 1; /* under site survey */
                rtw_hal_set_hwreg(padapter, HW_VAR_MLME_SITESURVEY, (u8 *)(&val8));
index a1663204a178b82fa90569578d7cb78820ce18d6..9284657e23c20d80a5a6103c3e1ad6759a510d19 100644 (file)
@@ -242,7 +242,7 @@ void Switch_DM_Func(struct adapter *padapter, u32 mode, u8 enable)
                rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_CLR, (u8 *)(&mode));
 }
 
-void Set_MSR(struct adapter *padapter, u8 type)
+void set_msr(struct adapter *padapter, u8 type)
 {
        rtw_hal_set_hwreg(padapter, HW_VAR_MEDIA_STATUS, (u8 *)(&type));
 }
index 31376cb8fca0fc45465359ae238ec13ae6015864..54dbcea89491a17d20a0e4440a58e5edadce18bd 100644 (file)
@@ -1944,7 +1944,7 @@ static void hw_var_set_opmode(struct adapter *padapter, u8 variable, u8 *val)
                rtw_write8(padapter, REG_BCN_CTRL, val8);
 
                /*  set net_type */
-               Set_MSR(padapter, mode);
+               set_msr(padapter, mode);
 
                if ((mode == _HW_STATE_STATION_) || (mode == _HW_STATE_NOLINK_)) {
                        {
index dd5080056e58348e9b41bf19c44ff90d334a71e4..afa5631a441a04c6d8ac23d16e9d1bb27a4682fe 100644 (file)
@@ -441,7 +441,7 @@ void Save_DM_Func_Flag(struct adapter *padapter);
 void Restore_DM_Func_Flag(struct adapter *padapter);
 void Switch_DM_Func(struct adapter *padapter, u32 mode, u8 enable);
 
-void Set_MSR(struct adapter *padapter, u8 type);
+void set_msr(struct adapter *padapter, u8 type);
 
 u8 rtw_get_oper_ch(struct adapter *adapter);
 void rtw_set_oper_ch(struct adapter *adapter, u8 ch);