Deprecate AES algorithm for DNS cookies

The AES algorithm for DNS cookies was being kept for legacy reasons,
and it can be safely removed in the next major release.  Mark is as
deprecated, so the `named-checkconf` prints a warning when in use.

(cherry picked from commit 67d14b0ee541b5bacf7c295b4231a49ae435941c)

diff --git a/lib/bind9/check.c b/lib/bind9/check.c
index 695090e02b8b708adfce0a1151317e69f28ef6f8..1c850d8e5a683c2bbeb58ae9cee4d8ef9389fbc8 100644 (file)
--- a/lib/bind9/check.c
+++ b/lib/bind9/check.c
@@ -1608,6 +1608,10 @@ check_options(const cfg_obj_t *options, const cfg_obj_t *config,
        (void)cfg_map_get(options, "cookie-algorithm", &obj);
        if (obj != NULL) {
                ccalg = cfg_obj_asstring(obj);
+               if (strcasecmp(ccalg, "aes") == 0) {
+                       cfg_obj_log(obj, logctx, ISC_LOG_WARNING,
+                                   "cookie-algorithm 'aes' is deprecated");
+               }
        }
 
        obj = NULL;