]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: qcom: glymur: Drop RPMh CXO clocks from QMP PHYs
authorAbel Vesa <abel.vesa@oss.qualcomm.com>
Tue, 14 Apr 2026 17:05:51 +0000 (20:05 +0300)
committerBjorn Andersson <andersson@kernel.org>
Tue, 12 May 2026 01:00:11 +0000 (20:00 -0500)
On Glymur, all QMP PHYs except the one used by USB SS0 take their
reference clock from the TCSR clock controller. Since these TCSR clocks
already derive from RPMH_CXO_CLK as their sole parent, there is no need
to provide an extra `clkref` clock to the PHY nodes.

Drop the extra RPMh CXO clock inputs and use the TCSR clocks as the PHY
reference clocks instead.

This also fixes the devicetree schema validation, as the bindings do not
allow a separate `clkref` clock.

Fixes: 4eee57dd4df9 ("arm64: dts: qcom: glymur: Add USB related nodes")
Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/r/20260410145205.GA554754-robh@kernel.org/
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260414-dts-glymur-drop-rpmh-cxo-clk-from-qmpphys-v1-1-ab12d77c4aec@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/glymur.dtsi

index f23cf81ddb77a4138deeb4e00dd8b316930a2feb..82436984485d41321d9caabfdd67ac8895b17b13 100644 (file)
 
                        clocks = <&gcc GCC_USB3_MP_PHY_AUX_CLK>,
                                 <&tcsr TCSR_USB3_0_CLKREF_EN>,
-                                <&rpmhcc RPMH_CXO_CLK>,
                                 <&gcc GCC_USB3_MP_PHY_COM_AUX_CLK>,
                                 <&gcc GCC_USB3_MP_PHY_PIPE_0_CLK>;
                        clock-names = "aux",
-                                     "clkref",
                                      "ref",
                                      "com_aux",
                                      "pipe";
 
                        clocks = <&gcc GCC_USB3_MP_PHY_AUX_CLK>,
                                 <&tcsr TCSR_USB3_1_CLKREF_EN>,
-                                <&rpmhcc RPMH_CXO_CLK>,
                                 <&gcc GCC_USB3_MP_PHY_COM_AUX_CLK>,
                                 <&gcc GCC_USB3_MP_PHY_PIPE_1_CLK>;
                        clock-names = "aux",
-                                     "clkref",
                                      "ref",
                                      "com_aux",
                                      "pipe";
                        reg = <0x0 0x00fde000 0x0 0x8000>;
 
                        clocks = <&gcc GCC_USB3_SEC_PHY_AUX_CLK>,
-                                <&rpmhcc RPMH_CXO_CLK>,
+                                <&tcsr TCSR_USB4_1_CLKREF_EN>,
                                 <&gcc GCC_USB3_SEC_PHY_COM_AUX_CLK>,
-                                <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>,
-                                <&tcsr TCSR_USB4_1_CLKREF_EN>;
+                                <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>;
                        clock-names = "aux",
                                      "ref",
                                      "com_aux",
-                                     "usb3_pipe",
-                                     "clkref";
+                                     "usb3_pipe";
 
                        power-domains = <&gcc GCC_USB_1_PHY_GDSC>;
 
                        reg = <0x0 0x088e1000 0x0 0x8000>;
 
                        clocks = <&gcc GCC_USB3_TERT_PHY_AUX_CLK>,
-                                <&rpmhcc RPMH_CXO_CLK>,
+                                <&tcsr TCSR_USB4_2_CLKREF_EN>,
                                 <&gcc GCC_USB3_TERT_PHY_COM_AUX_CLK>,
-                                <&gcc GCC_USB3_TERT_PHY_PIPE_CLK>,
-                                <&tcsr TCSR_USB4_2_CLKREF_EN>;
+                                <&gcc GCC_USB3_TERT_PHY_PIPE_CLK>;
                        clock-names = "aux",
                                      "ref",
                                      "com_aux",
-                                     "usb3_pipe",
-                                     "clkref";
+                                     "usb3_pipe";
 
                        power-domains = <&gcc GCC_USB_2_PHY_GDSC>;