]> git.ipfire.org Git - thirdparty/elfutils.git/commitdiff
libebl/eblinitreg_sample.c: potential off-by-one fix
authorSerhei Makarov <serhei@serhei.io>
Fri, 6 Mar 2026 17:21:47 +0000 (12:21 -0500)
committerSerhei Makarov <serhei@serhei.io>
Fri, 20 Mar 2026 18:12:42 +0000 (14:12 -0400)
{I believe the way things were setup on x86 meant this was never
triggered, but it looks incorrect.}

libebl/eblinitreg_sample.c

index 51fbe65d280785e455ec571e0df97e6c2d64b7ac..1f89c17e0cff7b980afa8c64e736ca08e3b25cba 100644 (file)
@@ -71,7 +71,7 @@ ebl_set_initial_registers_sample (Ebl *ebl,
     dwarf_regs[i] = 0x0;
   for (i = 0; i < n_regs; i++)
     {
-      if (i > n_regs_mapping)
+      if (i >= n_regs_mapping) /* TODO(REVIEW): off-by-one? */
        break;
       if (regs_mapping[i] < 0 || regs_mapping[i] >= (int)ebl->frame_nregs)
        continue;