]> git.ipfire.org Git - thirdparty/dhcpcd.git/commitdiff
eloop: set errno = EBADF rather than calling close if waitfd == -1 master
authorRoy Marples <roy@marples.name>
Wed, 27 May 2026 13:59:45 +0000 (14:59 +0100)
committerRoy Marples <roy@marples.name>
Wed, 27 May 2026 13:59:45 +0000 (14:59 +0100)
This avoids valgrind complaining.

src/eloop.c

index a65f6f186fb213f7a19fe0c12acb45a0ca11c730..b4967f17aa77d017eae11fcaba3a547ae86fbe7c 100644 (file)
@@ -997,7 +997,14 @@ int
 eloop_closefdwaiter(struct eloop *eloop)
 {
 #if defined(USE_KQUEUE) || defined(USE_EPOLL)
-       int err = close(eloop->waitfd);
+       int err;
+
+        if (eloop->waitfd == -1) {
+               errno = EBADF;
+               return -1;
+       }
+
+       err = close(eloop->waitfd);
        eloop->waitfd = -1;
        return err;
 #else