3692. [bug] Two calls to dns_db_getoriginnode were fatal if there

                        was no data at the node. [RT #35080]

diff --git a/CHANGES b/CHANGES
index 82919648d6331b3d11d0717851bf7ff64dd55693..5a0b1e8e09de8eae6cdfd3abb9b900e8144ba85c 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+3692.  [bug]           Two calls to dns_db_getoriginnode were fatal if there
+                       was no data at the node. [RT #35080]
+
 3691.  [contrib]       Address null pointer dereference in LDAP and
                        MySQL DLZ modules.
 

diff --git a/lib/dns/rbtdb.c b/lib/dns/rbtdb.c
index baafd718b5de5f0a4ae4fc579da53f2ab0df9edc..300f504ffa84fb75bd159def0d8a616096a33529 100644 (file)
--- a/lib/dns/rbtdb.c
+++ b/lib/dns/rbtdb.c
@@ -1870,8 +1870,11 @@ decrement_reference(dns_rbtdb_t *rbtdb, dns_rbtnode_t *node,
 
        nodelock = &rbtdb->node_locks[bucket];
 
+#define KEEP_NODE(n, r) \
+       ((n)->data != NULL || (n)->down != NULL || (n) == (r)->origin_node)
+
        /* Handle easy and typical case first. */
-       if (!node->dirty && (node->data != NULL || node->down != NULL)) {
+       if (!node->dirty && KEEP_NODE(node, rbtdb)) {
                dns_rbtnode_refdecrement(node, &nrefs);
                INSIST((int)nrefs >= 0);
                if (nrefs == 0) {
@@ -1940,12 +1943,11 @@ decrement_reference(dns_rbtdb_t *rbtdb, dns_rbtnode_t *node,
        isc_refcount_decrement(&nodelock->references, &refs);
        INSIST((int)refs >= 0);
 
-       /*
-        * XXXDCL should this only be done for cache zones?
-        */
-       if (node->data != NULL || node->down != NULL)
+       if (KEEP_NODE(node, rbtdb))
                goto restore_locks;
 
+#undef KEEP_NODE
+
        if (write_locked) {
                /*
                 * We can now delete the node.

diff --git a/lib/dns/tests/Makefile.in b/lib/dns/tests/Makefile.in
index caaaeb42db46e2ac1618a7b40e9edffbb86e4840..c847f1cfc9a63019f9ca4c2eb2f6127d9b5c5708 100644 (file)
--- a/lib/dns/tests/Makefile.in
+++ b/lib/dns/tests/Makefile.in
@@ -40,7 +40,8 @@ OBJS =                dnstest.@O@
 SRCS =         dnstest.c master_test.c dbiterator_test.c time_test.c \
                private_test.c update_test.c zonemgr_test.c zt_test.c \
                dbdiff_test.c geoip_test.c nsec3_test.c dispatch_test.c \
-               rbt_test.c rdata_test.c rdataset_test.c rdatasetstats_test.c
+               rbt_test.c rdata_test.c rdataset_test.c rdatasetstats_test.c \
+               db_test.c
 
 SUBDIRS =
 TARGETS =      master_test@EXEEXT@ dbiterator_test@EXEEXT@ time_test@EXEEXT@ \
@@ -48,7 +49,7 @@ TARGETS =     master_test@EXEEXT@ dbiterator_test@EXEEXT@ time_test@EXEEXT@ \
                zt_test@EXEEXT@ dbversion_test@EXEEXT@ dbdiff_test@EXEEXT@ \
                geoip_test@EXEEXT@ nsec3_test@EXEEXT@ dispatch_test@EXEEXT@ \
                rbt_test@EXEEXT@ rdata_test@EXEEXT@ rdataset_test@EXEEXT@ \
-               rdatasetstats_test@EXEEXT@ 
+               rdatasetstats_test@EXEEXT@ db_test@EXEEXT@
 
 @BIND9_MAKE_RULES@
 
@@ -139,6 +140,11 @@ geoip_test@EXEEXT@: geoip_test.@O@ ${ISCDEPLIBS} ${DNSDEPLIBS}
                        geoip_test.@O@ dnstest.@O@ ${DNSLIBS} \
                        ${ISCLIBS} ${LIBS}
 
+db_test@EXEEXT@: db_test.@O@ ${ISCDEPLIBS} ${DNSDEPLIBS}
+       ${LIBTOOL_MODE_LINK} ${PURIFY} ${CC} ${CFLAGS} ${LDFLAGS} -o $@ \
+                       db_test.@O@ ${DNSLIBS} \
+                       ${ISCLIBS} ${LIBS}
+
 unit::
        sh ${top_srcdir}/unit/unittest.sh
 

diff --git a/lib/dns/tests/db_test.c b/lib/dns/tests/db_test.c
new file mode 100644 (file)
index 0000000..f31c0ab
--- /dev/null
+++ b/lib/dns/tests/db_test.c
@@ -0,0 +1,86 @@
+/*
+ * Copyright (C) 2011, 2012  Internet Systems Consortium, Inc. ("ISC")
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS ALL WARRANTIES WITH
+ * REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
+ * AND FITNESS.  IN NO EVENT SHALL ISC BE LIABLE FOR ANY SPECIAL, DIRECT,
+ * INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
+ * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE
+ * OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
+ * PERFORMANCE OF THIS SOFTWARE.
+ */
+
+/* $Id$ */
+
+/*! \file */
+
+#include <config.h>
+
+#include <atf-c.h>
+
+#include <unistd.h>
+#include <stdlib.h>
+
+#include <dns/db.h>
+#include <dns/dbiterator.h>
+#include <dns/name.h>
+#include <dns/journal.h>
+
+#include "dnstest.h"
+
+/*
+ * Helper functions
+ */
+
+#define        BUFLEN          255
+#define        BIGBUFLEN       (64 * 1024)
+#define TEST_ORIGIN    "test"
+
+/*
+ * Individual unit tests
+ */
+
+ATF_TC(getoriginnode);
+ATF_TC_HEAD(getoriginnode, tc) {
+       atf_tc_set_md_var(tc, "descr",
+                         "test multiple calls to dns_db_getoriginnode");
+}
+ATF_TC_BODY(getoriginnode, tc) {
+       dns_db_t *db = NULL;
+       dns_dbnode_t *node = NULL;
+       isc_mem_t *mctx = NULL;
+       isc_result_t result;
+
+       result = isc_mem_create(0, 0, &mctx);
+       ATF_REQUIRE_EQ(result, ISC_R_SUCCESS);
+
+       result = isc_hash_create(mctx, NULL, 256);
+       ATF_REQUIRE_EQ(result, ISC_R_SUCCESS);
+
+       result = dns_db_create(mctx, "rbt", dns_rootname, dns_dbtype_zone,
+                           dns_rdataclass_in, 0, NULL, &db);
+       ATF_REQUIRE_EQ(result, ISC_R_SUCCESS);
+
+       result = dns_db_getoriginnode(db, &node);
+       ATF_REQUIRE_EQ(result, ISC_R_SUCCESS);
+       dns_db_detachnode(db, &node);
+
+       result = dns_db_getoriginnode(db, &node);
+       ATF_REQUIRE_EQ(result, ISC_R_SUCCESS);
+       dns_db_detachnode(db, &node);
+
+       dns_db_detach(&db);
+       isc_mem_detach(&mctx);
+}
+
+/*
+ * Main
+ */
+ATF_TP_ADD_TCS(tp) {
+       ATF_TP_ADD_TC(tp, getoriginnode);
+       return (atf_no_error());
+}