1800. [bug] Changes #1719 allowed a INSIST to be triggered.

                        [RT #13428]

diff --git a/CHANGES b/CHANGES
index 0490110651bb5784ceb25235282f2f479dd4f345..c7daf1b0338eb62243fd03a1a03cfc38074c3b73 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+1800.  [bug]           Changes #1719 allowed a INSIST to be triggered.
+                       [RT #13428]
+
 1799.  [placeholder]   rt13438
 
 1798.  [func]          The server syntax has been extended to support a

diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c
index 34c1113f98f2b8a2c8d4b2f53d2a1c178b4751ef..a1089849cbed7e1564e62644b86826b668ef53a2 100644 (file)
--- a/lib/dns/resolver.c
+++ b/lib/dns/resolver.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: resolver.c,v 1.299 2004/12/03 01:59:28 marka Exp $ */
+/* $Id: resolver.c,v 1.300 2005/01/19 23:25:41 marka Exp $ */
 
 #include <config.h>
 
@@ -4253,11 +4253,11 @@ noanswer_response(fetchctx_t *fctx, dns_name_t *oqname,
                        /*
                         * A negative response has a SOA record (Type 2) 
                         * and a optional NS RRset (Type 1) or it has neither
-                        * a SOA or a NS RRset (Type 3) or rcode is NXDOMAIN
-                        * (handled above) in which case the NS RRset is
-                        * allowed (Type 4).
+                        * a SOA or a NS RRset (Type 3, handled above) or
+                        * rcode is NXDOMAIN (handled above) in which case
+                        * the NS RRset is allowed (Type 4).
                         */
-                       if (soa_name != NULL || ns_name == NULL)
+                       if (soa_name != NULL)
                                negative_response = ISC_TRUE;
                        for (rdataset = ISC_LIST_HEAD(name->list);
                             rdataset != NULL;
@@ -5320,6 +5320,11 @@ resquery_response(isc_task_t *task, isc_event_t *event) {
        if ((fctx->res->options & DNS_RESOLVER_CHECKNAMES) != 0)
                checknames(message);
 
+       /*
+        * Clear cache bits.
+        */
+       fctx->attributes &= ~(FCTX_ATTR_WANTNCACHE | FCTX_ATTR_WANTCACHE);
+
        /*
         * Did we get any answers?
         */