]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
address coverity warnings in delv
authorEvan Hunt <each@isc.org>
Mon, 3 Apr 2023 17:43:32 +0000 (10:43 -0700)
committerEvan Hunt <each@isc.org>
Wed, 5 Apr 2023 18:19:22 +0000 (11:19 -0700)
clean up coverity warnings due to recent changes to delv:
- CID 451097: failure to check return value from inet_pton()
- CID 451098, 451100: dead code

bin/delv/delv.c

index 91ebe62348124fe08ac20cb9426d827b98de6e32..8d68782d101211bfeb5fac14f41d0490c0791d8e 100644 (file)
@@ -2088,12 +2088,6 @@ sendquery(void *arg) {
 
 cleanup:
        if (message != NULL) {
-               if (mname != NULL) {
-                       dns_message_puttempname(message, &mname);
-               }
-               if (mrdataset != NULL) {
-                       dns_message_puttemprdataset(message, &mrdataset);
-               }
                dns_message_detach(&message);
        }
 
@@ -2123,7 +2117,7 @@ run_server(void *arg) {
 
        UNUSED(arg);
 
-       inet_pton(AF_INET, "127.0.0.1", &in);
+       RUNTIME_CHECK(inet_pton(AF_INET, "127.0.0.1", &in));
        isc_sockaddr_fromin(&addr, &in, 0);
 
        CHECK(ns_server_create(mctx, matchview, &sctx));