]> git.ipfire.org Git - thirdparty/gnutls.git/commitdiff
gnutls_memset(): calling explicit_bzero() is enough to zero-fill a buffer
authorMaciej S. Szmigiero <mail@maciej.szmigiero.name>
Thu, 28 Mar 2019 22:04:13 +0000 (23:04 +0100)
committerNikos Mavrogiannopoulos <nmav@gnutls.org>
Fri, 5 Apr 2019 16:19:50 +0000 (18:19 +0200)
If we use explicit_bzero() to zero-fill a buffer in gnutls_memset() we
don't need to zero it again via a volatile trick later in this function.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
lib/safe-memfuncs.c

index a9db39d2a7e27b7a3e5b65e65ff74df212f00765..b957b432cd87d28337df984f31582d862bdb404b 100644 (file)
@@ -39,6 +39,7 @@ void gnutls_memset(void *data, int c, size_t size)
 #ifdef HAVE_EXPLICIT_BZERO
        if (c == 0) {
                explicit_bzero(data, size);
+               return;
        }
 #endif
        volatile_zero = 0;