]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
named: Add INSIST() after bindkeysfile configuration load to silence scan-build FP
authorOndřej Surý <ondrej@sury.org>
Sun, 13 Oct 2019 04:47:26 +0000 (06:47 +0200)
committerOndřej Surý <ondrej@sury.org>
Tue, 5 Nov 2019 08:49:58 +0000 (09:49 +0100)
(cherry picked from commit 6bf364aec87773764c2850a95251aa6a15cf320e)

bin/named/server.c

index ad2cd5f23bd896feb403b66cb5f0e74691ced923..b5f164eebb13e0988ff32c1ad52535ba341786ea 100644 (file)
@@ -7555,6 +7555,7 @@ load_configuration(const char *filename, ns_server_t *server,
        INSIST(result == ISC_R_SUCCESS);
        CHECKM(setstring(server, &server->bindkeysfile,
               cfg_obj_asstring(obj)), "strdup");
+       INSIST(server->bindkeysfile != NULL);
 
        if (access(server->bindkeysfile, R_OK) == 0) {
                isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,