samba-tool tests: test dns --allow-existing

This will fail until the next commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13613

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Rowland Penny <rpenny@samba.org>

diff --git a/python/samba/tests/samba_tool/dnscmd.py b/python/samba/tests/samba_tool/dnscmd.py
index d372bc5851e601cba2fca307e0bdd2cee50952fa..aa475fb84ac1378a4e1283fe73d05418ecf29bb4 100644 (file)
--- a/python/samba/tests/samba_tool/dnscmd.py
+++ b/python/samba/tests/samba_tool/dnscmd.py
@@ -648,6 +648,19 @@ class DnsCmdTestCase(SambaToolCmdTest):
                                               self.good_records[record_type][0],
                                               self.creds_string)
             self.assertCmdFail(result)
+            # Now we repeat the second add with --allow-existing,
+            # which should not complain.
+            result, out, err = self.runsubcmd("dns", "add",
+                                              os.environ["SERVER"],
+                                              self.zone, "testrecord",
+                                              record_type,
+                                              self.good_records[record_type][0],
+                                              self.creds_string,
+                                              "--allow-existing",
+                                              catch_error=True)
+            self.assertCmdSuccess(result, out, err)
+            self.assertIn("Record already exists", out)
+
             result, out, err = self.runsubcmd("dns", "query",
                                               os.environ["SERVER"],
                                               self.zone, "testrecord",

diff --git a/selftest/knownfail.d/samba-tool-dns-add-duplicate-record b/selftest/knownfail.d/samba-tool-dns-add-duplicate-record
new file mode 100644 (file)
index 0000000..cfb441a
--- /dev/null
+++ b/selftest/knownfail.d/samba-tool-dns-add-duplicate-record
@@ -0,0 +1 @@
+samba.tests.samba_tool.dnscmd.+DnsCmdTestCase.test_add_duplicate_record