]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
xen/mcelog: mark g_physinfo, ncpus and xen_mce_chrdev_device as __ro_after_init
authorLen Bao <len.bao@gmx.us>
Sat, 23 May 2026 13:28:01 +0000 (13:28 +0000)
committerJuergen Gross <jgross@suse.com>
Mon, 8 Jun 2026 07:01:02 +0000 (09:01 +0200)
The 'g_physinfo' and 'ncpus' variables are initialized only during the
init phase in the 'bind_virq_for_mce' function and never changed. So,
mark them as __ro_after_init.

The 'xen_mce_chrdev_device' variable is initialized only in the
declaration and never changed. So, this variable could be 'const', but
using the 'misc_register' and 'misc_deregister' functions discards the
'const' qualifier. Therefore, as an alternative, mark it as
__ro_after_init.

Signed-off-by: Len Bao <len.bao@gmx.us>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Message-ID: <20260523132802.25391-1-len.bao@gmx.us>

drivers/xen/mcelog.c

index 53a8720f5caebb6cb5af11b769f91bfa6fc8435b..32ab419bb5034ebf3e84de86672f16ad6f3d82d1 100644 (file)
@@ -54,8 +54,8 @@
 #include <asm/xen/hypervisor.h>
 
 static struct mc_info g_mi;
-static struct mcinfo_logical_cpu *g_physinfo;
-static uint32_t ncpus;
+static struct mcinfo_logical_cpu *g_physinfo __ro_after_init;
+static uint32_t ncpus __ro_after_init;
 
 static DEFINE_MUTEX(mcelog_lock);
 
@@ -182,7 +182,7 @@ static const struct file_operations xen_mce_chrdev_ops = {
        .unlocked_ioctl         = xen_mce_chrdev_ioctl,
 };
 
-static struct miscdevice xen_mce_chrdev_device = {
+static struct miscdevice xen_mce_chrdev_device __ro_after_init = {
        MISC_MCELOG_MINOR,
        "mcelog",
        &xen_mce_chrdev_ops,