mtd: rawnand: pl353: fix probe resource allocation

During probe(), the devm_ioremap() is called with the parent device
instead of the current one. So when the module is unloaded, the register
area isn't released.

Target the pl35x device in the devm_ioremap() instead of its parent.

Cc: stable@vger.kernel.org
Fixes: 08d8c62164a3 ("mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller")
Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c
index f2c65eb7a8d9aaa36c44d78ddbb39f4bb639fc04..06f8f1e14b9c2c0f6a82c43231e088ac41fb66ca 100644 (file)
--- a/drivers/mtd/nand/raw/pl35x-nand-controller.c
+++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c
@@ -1155,7 +1155,7 @@ static int pl35x_nand_probe(struct platform_device *pdev)
        nfc->controller.ops = &pl35x_nandc_ops;
        INIT_LIST_HEAD(&nfc->chips);
 
-       nfc->conf_regs = devm_ioremap_resource(&smc_amba->dev, &smc_amba->res);
+       nfc->conf_regs = devm_ioremap_resource(nfc->dev, &smc_amba->res);
        if (IS_ERR(nfc->conf_regs))
                return PTR_ERR(nfc->conf_regs);