bloom: remove a misleading const qualifier

When building with glibc-2.43 there is the following warning:

    bloom.c: In function ‘get_or_compute_bloom_filter’:
    bloom.c:515:52: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
      515 |                                 char *last_slash = strrchr(path, '/');
          |                                                    ^~~~~~~

In this case, we always write through "path" through the "last_slash"
pointer. Therefore, the const qualifier on "path" is misleading and we
can just remove it.

Signed-off-by: Collin Funk <collin.funk1@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/bloom.c b/bloom.c
index 2d7b951e5bf24592e5f0c830ef04b7786768f359..d604e8f07ab8d8c47b5de8d0ffc7c4cd606b6cfc 100644 (file)
--- a/bloom.c
+++ b/bloom.c
@@ -501,7 +501,7 @@ struct bloom_filter *get_or_compute_bloom_filter(struct repository *r,
                struct hashmap_iter iter;
 
                for (i = 0; i < diff_queued_diff.nr; i++) {
-                       const char *path = diff_queued_diff.queue[i]->two->path;
+                       char *path = diff_queued_diff.queue[i]->two->path;
 
                        /*
                         * Add each leading directory of the changed file, i.e. for
@@ -523,7 +523,7 @@ struct bloom_filter *get_or_compute_bloom_filter(struct repository *r,
                                        free(e);
 
                                if (!last_slash)
-                                       last_slash = (char*)path;
+                                       last_slash = path;
                                *last_slash = '\0';
 
                        } while (*path);