]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
power: regulator: pfuze100: Fix unchecked pmic_reg_read, return value
authorFrancois Berder <fberder@outlook.fr>
Fri, 8 May 2026 20:11:35 +0000 (22:11 +0200)
committerFabio Estevam <festevam@gmail.com>
Fri, 15 May 2026 20:31:39 +0000 (17:31 -0300)
pmic_reg_read returns a negative value if an error occurs. This
commit adds a missing check after calling pmic_reg_read.

Signed-off-by: Francois Berder <fberder@outlook.fr>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
drivers/power/regulator/pfuze100.c

index 77c82a00b65557b1baf37ebf576709677634802e..57af16cfbb9c50d792ff5bde20a4b4b0f5ba3d69 100644 (file)
@@ -550,6 +550,8 @@ static int pfuze100_regulator_val(struct udevice *dev, int op, int *uV)
                        return -EINVAL;
                }
                val = pmic_reg_read(dev->parent, desc->vsel_reg);
+               if (val < 0)
+                       return val;
                if (desc->high_volt_mask && (val & desc->high_volt_mask)) {
                        min_uV = desc->high_volt_desc->min_uV;
                        uV_step = desc->high_volt_desc->uV_step;