'noqname' must be non NULL, remove test.

6367cleanup:
6368        dns_rdataset_disassociate(&neg);
6369        dns_rdataset_disassociate(&negsig);

	CID 1452704 (#1 of 1): Dereference before null check
	(REVERSE_INULL) check_after_deref: Null-checking noqname
	suggests that it may be null, but it has already been
	dereferenced on all paths leading to the check.

6370        if (noqname != NULL)
6371                free_noqname(mctx, &noqname);

diff --git a/lib/dns/rbtdb.c b/lib/dns/rbtdb.c
index 4c2b46c593e85303e019320da36de6be2393b31e..e2c9df1cf4cf20bfe93c0405f5be8841c9c8c6cf 100644 (file)
--- a/lib/dns/rbtdb.c
+++ b/lib/dns/rbtdb.c
@@ -6368,8 +6368,7 @@ addnoqname(dns_rbtdb_t *rbtdb, rdatasetheader_t *newheader,
 cleanup:
        dns_rdataset_disassociate(&neg);
        dns_rdataset_disassociate(&negsig);
-       if (noqname != NULL)
-               free_noqname(mctx, &noqname);
+       free_noqname(mctx, &noqname);
        return(result);
 }