]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix wrong variable in named_server_sync() log message 12090/head
authorMichal Nowak <mnowak@isc.org>
Mon, 25 May 2026 06:52:31 +0000 (06:52 +0000)
committerMichal Nowak <mnowak@isc.org>
Mon, 1 Jun 2026 14:02:08 +0000 (16:02 +0200)
named_server_sync() logged isc_result_totext(result) but returns
tresult. The loop accumulates errors into tresult, so result only
holds the last iteration's value. If the last view succeeded but an
earlier one failed, the log would incorrectly say "success".

Assisted-by: Claude:claude-opus-4-7
bin/named/server.c

index c58a01467e721d1ca00fb8af3cbbdc58f8379ec0..906e108b9a4f77ce4cf618801a80dd4c49a6aed0 100644 (file)
@@ -11807,7 +11807,7 @@ named_server_sync(named_server_t *server, isc_lex_t *lex, isc_buffer_t *text) {
                isc_log_write(NAMED_LOGCATEGORY_GENERAL, NAMED_LOGMODULE_SERVER,
                              ISC_LOG_INFO, "dumping all zones%s: %s",
                              cleanup ? ", removing journal files" : "",
-                             isc_result_totext(result));
+                             isc_result_totext(tresult));
                return tresult;
        }