1868. [func] edns-udp-size can now be overridden on a per

                        server basis. [RT #14851]

diff --git a/CHANGES b/CHANGES
index ee880612b64897f583c792c4404d8b961a9a6236..511ed8b9582aeb621a0b2a461e95c554e50ee506 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -3,7 +3,8 @@
 1878.  [func]          dig can now specify the EDNS version when making
                        a query.
 
-1868.  [placeholder]   rt14851
+1868.  [func]          edns-udp-size can now be overridden on a per
+                       server basis. [RT #14851]
 
 1867.  [placeholder]   rt14846
 

diff --git a/bin/named/named.conf.docbook b/bin/named/named.conf.docbook
index 1534681b4a862e9bf9d6cb48b656e8ae97dbb178..a00cf8760b045b70c64c8fe51a1cc35f6fe5df65 100644 (file)
--- a/bin/named/named.conf.docbook
+++ b/bin/named/named.conf.docbook
@@ -17,7 +17,7 @@
  - PERFORMANCE OF THIS SOFTWARE.
 -->
 
-<!-- $Id: named.conf.docbook,v 1.11 2005/05/19 04:59:00 marka Exp $ -->
+<!-- $Id: named.conf.docbook,v 1.12 2005/06/07 00:27:31 marka Exp $ -->
 <refentry>
   <refentryinfo>
     <date>Aug 13, 2004</date>
@@ -102,6 +102,7 @@ masters <replaceable>string</replaceable> <optional> port <replaceable>integer</
 server ( <replaceable>ipv4_address<optional>/prefixlen</optional></replaceable> | <replaceable>ipv6_address<optional>/prefixlen</optional></replaceable> ) {
        bogus <replaceable>boolean</replaceable>;
        edns <replaceable>boolean</replaceable>;
+       edns-udp-size <replaceable>integer</replaceable>;
        provide-ixfr <replaceable>boolean</replaceable>;
        request-ixfr <replaceable>boolean</replaceable>;
        keys <replaceable>server_key</replaceable>;

diff --git a/bin/named/server.c b/bin/named/server.c
index 947457b3a73a9ad3b2bf283d4326be41009047ec..4fa3f19dc66776bd895b2a94448e2d7e4fd20805 100644 (file)
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: server.c,v 1.442 2005/04/29 00:36:15 marka Exp $ */
+/* $Id: server.c,v 1.443 2005/06/07 00:27:32 marka Exp $ */
 
 /*! \file */
 
@@ -620,6 +620,17 @@ configure_peer(cfg_obj_t *cpeer, isc_mem_t *mctx, dns_peer_t **peerp) {
        if (obj != NULL)
                CHECK(dns_peer_setsupportedns(peer, cfg_obj_asboolean(obj)));
 
+       obj = NULL;
+       (void)cfg_map_get(cpeer, "edns-udp-size", &obj);
+       if (obj != NULL) {
+               isc_uint32_t udpsize = cfg_obj_asuint32(obj);
+               if (udpsize < 512)
+                       udpsize = 512;
+               if (udpsize > 4096)
+                       udpsize = 4096;
+               CHECK(dns_peer_setudpsize(peer, (isc_uint16_t)udpsize));
+       }
+
        obj = NULL;
        (void)cfg_map_get(cpeer, "transfers", &obj);
        if (obj != NULL)

diff --git a/doc/arm/Bv9ARM-book.xml b/doc/arm/Bv9ARM-book.xml
index 35af0efb28d2527db5859db9405524e99fdc677f..ab2d0c642e94dab6300d36438136e8cc60db3f4c 100644 (file)
--- a/doc/arm/Bv9ARM-book.xml
+++ b/doc/arm/Bv9ARM-book.xml
@@ -18,7 +18,7 @@
  - PERFORMANCE OF THIS SOFTWARE.
 -->
 
-<!-- File: $Id: Bv9ARM-book.xml,v 1.269 2005/05/19 04:59:01 marka Exp $ -->
+<!-- File: $Id: Bv9ARM-book.xml,v 1.270 2005/06/07 00:27:32 marka Exp $ -->
 <book>
   <title>BIND 9 Administrator Reference Manual</title>
 
@@ -7181,6 +7181,7 @@ query-source-v6 address * port *;
     <optional> provide-ixfr <replaceable>yes_or_no</replaceable> ; </optional>
     <optional> request-ixfr <replaceable>yes_or_no</replaceable> ; </optional>
     <optional> edns <replaceable>yes_or_no</replaceable> ; </optional>
+    <optional> edns-udp-size <replaceable>number</replaceable> ; </optional>
     <optional> transfers <replaceable>number</replaceable> ; </optional>
     <optional> transfer-format <replaceable>( one-answer | many-answers )</replaceable> ; ]</optional>
     <optional> keys <replaceable>{ string ; <optional> string ; <optional>...</optional></optional> }</replaceable> ; </optional>
@@ -7271,10 +7272,18 @@ query-source-v6 address * port *;
 
           <para>
             The <command>edns</command> clause determines whether
-            the local server
-            will attempt to use EDNS when communicating with the remote
-            server.  The
-            default is <command>yes</command>.
+            the local server will attempt to use EDNS when communicating
+           with the remote server.  The default is <command>yes</command>.
+          </para>
+
+          <para>
+            The <command>edns-udp-size</command> option sets the EDNS UDP size
+           that is advertised by named when querying the remote server.
+           Valid values are 512 to 4096 (values outside this range will be
+           silently adjusted).  This option is useful when you wish to
+           advertises a different value to this server than the value you
+           advertise globally, for example, when there is a firewall at the
+           remote site that is blocking large replies.
           </para>
 
           <para>

diff --git a/doc/misc/options b/doc/misc/options
index 16ff3398acbbdc95a644be3024cdcc27f0303d98..2f6a6b3cfdabcf491e9b6e31a9f45f4b1e0e1d28 100644 (file)
--- a/doc/misc/options
+++ b/doc/misc/options
@@ -238,6 +238,7 @@ view <string> <optional_class> {
                 transfer-format ( many-answers | one-answer );
                 keys <server_key>;
                 edns <boolean>;
+                edns-udp-size <integer>;
                 transfer-source ( <ipv4_address> | * ) [ port ( <integer> |
                     * ) ];
                 transfer-source-v6 ( <ipv6_address> | * ) [ port (
@@ -407,6 +408,7 @@ server <netprefix> {
         transfer-format ( many-answers | one-answer );
         keys <server_key>;
         edns <boolean>;
+        edns-udp-size <integer>;
         transfer-source ( <ipv4_address> | * ) [ port ( <integer> | * ) ];
         transfer-source-v6 ( <ipv6_address> | * ) [ port ( <integer> | * ) ];
 };

diff --git a/lib/dns/include/dns/peer.h b/lib/dns/include/dns/peer.h
index e8de6e3b9c78ac6e21b58b8b3d8fdcc382342e13..f9200ab9f3726165612b600a6e629872c4c6ad44 100644 (file)
--- a/lib/dns/include/dns/peer.h
+++ b/lib/dns/include/dns/peer.h
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: peer.h,v 1.23 2005/04/27 04:56:57 sra Exp $ */
+/* $Id: peer.h,v 1.24 2005/06/07 00:27:34 marka Exp $ */
 
 #ifndef DNS_PEER_H
 #define DNS_PEER_H 1
@@ -75,6 +75,7 @@ struct dns_peer {
        isc_boolean_t           support_edns;
        dns_name_t             *key;
        isc_sockaddr_t         *transfer_source;
+       isc_uint16_t            udpsize;
 
        isc_uint32_t            bitflags;
 
@@ -178,6 +179,12 @@ dns_peer_settransfersource(dns_peer_t *peer, isc_sockaddr_t *transfer_source);
 isc_result_t
 dns_peer_gettransfersource(dns_peer_t *peer, isc_sockaddr_t *transfer_source);
 
+isc_result_t
+dns_peer_setudpsize(dns_peer_t *peer, isc_uint16_t udpsize);
+
+isc_result_t
+dns_peer_getudpsize(dns_peer_t *peer, isc_uint16_t *udpsize);
+
 ISC_LANG_ENDDECLS
 
 #endif /* DNS_PEER_H */

diff --git a/lib/dns/peer.c b/lib/dns/peer.c
index 081398168aad01766c5343177341d567f3673647..6334a19f83732297213642019c29876eb5ee2dda 100644 (file)
--- a/lib/dns/peer.c
+++ b/lib/dns/peer.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: peer.c,v 1.22 2005/04/27 04:56:49 sra Exp $ */
+/* $Id: peer.c,v 1.23 2005/06/07 00:27:33 marka Exp $ */
 
 /*! \file */
 
@@ -40,6 +40,7 @@
 #define PROVIDE_IXFR_BIT               3
 #define REQUEST_IXFR_BIT               4
 #define SUPPORT_EDNS_BIT               5
+#define SERVER_UDPSIZE_BIT             6
 
 static void
 peerlist_delete(dns_peerlist_t **list);
@@ -558,3 +559,31 @@ dns_peer_gettransfersource(dns_peer_t *peer, isc_sockaddr_t *transfer_source) {
        *transfer_source = *peer->transfer_source;
        return (ISC_R_SUCCESS);
 }
+
+isc_result_t
+dns_peer_setudpsize(dns_peer_t *peer, isc_uint16_t udpsize) {
+       isc_boolean_t existed;
+
+       REQUIRE(DNS_PEER_VALID(peer));
+
+       existed = DNS_BIT_CHECK(SERVER_UDPSIZE_BIT, &peer->bitflags);
+
+       peer->udpsize = udpsize;
+       DNS_BIT_SET(SERVER_UDPSIZE_BIT, &peer->bitflags);
+
+       return (existed ? ISC_R_EXISTS : ISC_R_SUCCESS);
+}
+
+isc_result_t
+dns_peer_getudpsize(dns_peer_t *peer, isc_uint16_t *udpsize) {
+
+       REQUIRE(DNS_PEER_VALID(peer));
+       REQUIRE(udpsize != NULL);
+
+       if (DNS_BIT_CHECK(SERVER_UDPSIZE_BIT, &peer->bitflags)) {
+                *udpsize = peer->udpsize;
+                return (ISC_R_SUCCESS);
+        } else {
+                return (ISC_R_NOTFOUND);
+        }
+}

diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c
index f03b5dd283a0ccf7fa89553d4c8c555d3b179598..ae4e4cea10bd09693c11ff594d0d8b494136f8ac 100644 (file)
--- a/lib/dns/resolver.c
+++ b/lib/dns/resolver.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: resolver.c,v 1.309 2005/06/07 00:16:00 marka Exp $ */
+/* $Id: resolver.c,v 1.310 2005/06/07 00:27:33 marka Exp $ */
 
 /*! \file */
 
@@ -841,7 +841,8 @@ resquery_senddone(isc_task_t *task, isc_event_t *event) {
 }
 
 static inline isc_result_t
-fctx_addopt(dns_message_t *message, unsigned int version, dns_resolver_t *res) {
+fctx_addopt(dns_message_t *message, unsigned int version, isc_uint16_t udpsize)
+{ 
        dns_rdataset_t *rdataset;
        dns_rdatalist_t *rdatalist;
        dns_rdata_t *rdata;
@@ -867,7 +868,7 @@ fctx_addopt(dns_message_t *message, unsigned int version, dns_resolver_t *res) {
        /*
         * Set Maximum UDP buffer size.
         */
-       rdatalist->rdclass = res->udpsize;
+       rdatalist->rdclass = udpsize;
 
        /*
         * Set EXTENDED-RCODE and Z to 0, DO to 1.
@@ -1236,12 +1237,16 @@ resquery_send(resquery_t *query) {
                if ((query->addrinfo->flags & DNS_FETCHOPT_NOEDNS0) == 0) {
                        unsigned int version = 0;       /* Default version. */
                        unsigned int flags;
+                       isc_uint16_t udpsize = res->udpsize;
+
                        flags = query->addrinfo->flags;
                        if ((flags & DNS_FETCHOPT_EDNSVERSIONSET) != 0) {
                                version = flags & DNS_FETCHOPT_EDNSVERSIONMASK;
                                version >>= DNS_FETCHOPT_EDNSVERSIONSHIFT;
                        }
-                       result = fctx_addopt(fctx->qmessage, version, res);
+                       if (peer != NULL)
+                               (void)dns_peer_getudpsize(peer, &udpsize);
+                       result = fctx_addopt(fctx->qmessage, version, udpsize);
                        if (result != ISC_R_SUCCESS) {
                                /*
                                 * We couldn't add the OPT, but we'll press on.

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index 344be623627747c1802d1b300598e07ee45f70ab..c513379613fc3bf7281523bb68c9898845ba58ef 100644 (file)
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: zone.c,v 1.436 2005/06/04 05:32:47 jinmei Exp $ */
+/* $Id: zone.c,v 1.437 2005/06/07 00:27:33 marka Exp $ */
 
 /*! \file */
 
@@ -4430,7 +4430,7 @@ create_query(dns_zone_t *zone, dns_rdatatype_t rdtype,
 }
 
 static isc_result_t
-add_opt(dns_message_t *message) {
+add_opt(dns_message_t *message, isc_uint16_t udpsize) {
        dns_rdataset_t *rdataset = NULL;
        dns_rdatalist_t *rdatalist = NULL;
        dns_rdata_t *rdata = NULL;
@@ -4453,7 +4453,7 @@ add_opt(dns_message_t *message) {
        /*
         * Set Maximum UDP buffer size.
         */
-       rdatalist->rdclass = SEND_BUFFER_SIZE;
+       rdatalist->rdclass = udpsize;
 
        /*
         * Set EXTENDED-RCODE, VERSION, DO and Z to 0.
@@ -4500,6 +4500,7 @@ soa_query(isc_task_t *task, isc_event_t *event) {
        isc_boolean_t cancel = ISC_TRUE;
        int timeout;
        isc_boolean_t have_xfrsource;
+       isc_uint16_t udpsize = SEND_BUFFER_SIZE;
 
        REQUIRE(DNS_ZONE_VALID(zone));
 
@@ -4563,6 +4564,10 @@ soa_query(isc_task_t *task, isc_event_t *event) {
                                                            &zone->sourceaddr);
                        if (result == ISC_R_SUCCESS)
                                have_xfrsource = ISC_TRUE;
+                       if (zone->view->resolver != NULL)
+                               udpsize =
+                                 dns_resolver_getudpsize(zone->view->resolver);
+                       (void)dns_peer_getudpsize(peer, &udpsize);
                }
        }
 
@@ -4594,7 +4599,7 @@ soa_query(isc_task_t *task, isc_event_t *event) {
                  DNS_REQUESTOPT_TCP : 0;
 
        if (!DNS_ZONE_FLAG(zone, DNS_ZONEFLG_NOEDNS)) {
-               result = add_opt(message);
+               result = add_opt(message, udpsize);
                if (result != ISC_R_SUCCESS)
                        zone_debuglog(zone, me, 1,
                                      "unable to add opt record: %s",
@@ -4653,6 +4658,7 @@ ns_query(dns_zone_t *zone, dns_rdataset_t *soardataset, dns_stub_t *stub) {
        dns_dbnode_t *node = NULL;
        int timeout;
        isc_boolean_t have_xfrsource = ISC_FALSE;
+       isc_uint16_t udpsize = SEND_BUFFER_SIZE;
 
        REQUIRE(DNS_ZONE_VALID(zone));
        REQUIRE((soardataset != NULL && stub == NULL) ||
@@ -4776,11 +4782,15 @@ ns_query(dns_zone_t *zone, dns_rdataset_t *soardataset, dns_stub_t *stub) {
                                                            &zone->sourceaddr);
                        if (result == ISC_R_SUCCESS)
                                have_xfrsource = ISC_TRUE;
+                       if (zone->view->resolver != NULL)
+                               udpsize =
+                                 dns_resolver_getudpsize(zone->view->resolver);
+                       (void)dns_peer_getudpsize(peer, &udpsize);
                }
                
        }
        if (!DNS_ZONE_FLAG(zone, DNS_ZONEFLG_NOEDNS)) {
-               result = add_opt(message);
+               result = add_opt(message, udpsize);
                if (result != ISC_R_SUCCESS)
                        zone_debuglog(zone, me, 1,
                                      "unable to add opt record: %s",

diff --git a/lib/isccfg/namedconf.c b/lib/isccfg/namedconf.c
index 593eb872099e01e6adc043cbdc2ad09f6268fbdc..ea4f04cfd8bf65116f0e6ad1fd05fcef65d87206 100644 (file)
--- a/lib/isccfg/namedconf.c
+++ b/lib/isccfg/namedconf.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: namedconf.c,v 1.50 2005/05/19 04:59:05 marka Exp $ */
+/* $Id: namedconf.c,v 1.51 2005/06/07 00:27:34 marka Exp $ */
 
 /*! \file */
 
@@ -907,6 +907,7 @@ server_clauses[] = {
        { "transfer-format", &cfg_type_transferformat, 0 },
        { "keys", &cfg_type_server_key_kludge, 0 },
        { "edns", &cfg_type_boolean, 0 },
+       { "edns-udp-size", &cfg_type_uint32, 0 },
        { "transfer-source", &cfg_type_sockaddr4wild, 0 },
        { "transfer-source-v6", &cfg_type_sockaddr6wild, 0 },
        { NULL, NULL, 0 }