]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix dig connection timeout argument when using DOH
authorMatthijs Mekking <matthijs@isc.org>
Tue, 23 Jul 2024 08:57:13 +0000 (10:57 +0200)
committerMatthijs Mekking <matthijs@isc.org>
Tue, 30 Jul 2024 08:52:05 +0000 (08:52 +0000)
bin/dig/dighost.c calls isc_nm_httpconnect. The timeout setting
(local_timeout) is passed as the 11th argument, but the function in
lib/isc/netmgr/http.c has the timeout argument as the 11th argument.
The 10th and 11th argument were reversed. This commit fixes that.

Thanks to Nicolas Dehaine for reporting and providing the fix.

bin/dig/dighost.c

index 5d40c6155f4c9797d1ee4d2fd1b6a2c58952de60..9e500de77f47dc5e9f1d6cd9219ab24b2ffc5da8 100644 (file)
@@ -3086,7 +3086,7 @@ start_tcp(dig_query_t *query) {
                        isc_nm_httpconnect(netmgr, &localaddr, &query->sockaddr,
                                           uri, !query->lookup->https_get,
                                           tcp_connected, connectquery, tlsctx,
-                                          sess_cache, 0, local_timeout);
+                                          sess_cache, local_timeout, 0);
 #endif
                } else {
                        isc_nm_tcpdnsconnect(netmgr, &localaddr,