]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
GHA/windows: disable `taskkill` in torture jobs
authorViktor Szakats <commit@vsz.me>
Fri, 20 Mar 2026 18:00:44 +0000 (19:00 +0100)
committerViktor Szakats <commit@vsz.me>
Fri, 20 Mar 2026 18:53:11 +0000 (19:53 +0100)
As an experiment.

Also:
- processhelp.pm: log when `taskkill` is force-skipped.

Ref: #21035

Follow-up to f450f3801b6b9dff0ea280f5fb4bf28203f7b313 #19897
Follow-up to 2701ac6a4d16a62130dad05be1c484903b8545c7 #19421

Closes #21039

.github/workflows/windows.yml
tests/processhelp.pm

index c2c56c0abf7bcf479a66b5fe093521f5b23f9106..edd31632c6e27351a40a2545f44300a928456ac3 100644 (file)
@@ -431,6 +431,7 @@ jobs:
             fi
             if [[ "${TFLAGS}" = *'-t'* ]]; then
               TFLAGS+=' !2300'  # Leaks memory and file handle via tool_doswin.c / win32_stdin_read_thread()
+              export CURL_TEST_NO_TASKKILL=1  # experiment to see if it reduces flaky failures
             fi
           fi
           if [ -x "$(cygpath "${SYSTEMROOT}/System32/curl.exe")" ]; then
index 1ff51f339e6525c3a61b8ecb589386e711d898de..299bce0d8a5be83075ef910c72035fcb1588f030 100644 (file)
@@ -192,6 +192,9 @@ sub pidterm {
                         print "Executing: '$cmd'\n";
                         system($cmd);
                     }
+                    else {
+                        print "taskkill disabled via CURL_TEST_NO_TASKKILL.\n";
+                    }
                 }
                 return;
             }
@@ -240,6 +243,9 @@ sub pidkill {
                         print "Executing: '$cmd'\n";
                         system($cmd);
                     }
+                    else {
+                        print "taskkill disabled via CURL_TEST_NO_TASKKILL.\n";
+                    }
                 }
                 return;
             }