]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
soc: rockchip: grf: Add missing of_node_put() when returning
authorShawn Lin <shawn.lin@rock-chips.com>
Wed, 11 Feb 2026 13:02:37 +0000 (21:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Mar 2026 10:08:51 +0000 (11:08 +0100)
[ Upstream commit 24ed11ee5bacf9a9aca18fc6b47667c7f38d578b ]

Fix the smatch checking:
drivers/soc/rockchip/grf.c:249 rockchip_grf_init()
warn: inconsistent refcounting 'np->kobj.kref.refcount.refs.counter':

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: 75fb63ae0312 ("soc: rockchip: grf: Support multiple grf to be handled")
Closes: https://lore.kernel.org/all/aYXvgTcUJWQL2can@stanley.mountain/
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Link: https://patch.msgid.link/1770814957-17762-1-git-send-email-shawn.lin@rock-chips.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/rockchip/grf.c

index dddfe349b3da3727ccb17b8c5f59672860b9f1c8..6fd02220abf1d0b07c3d362df7cb7626207004f3 100644 (file)
@@ -217,6 +217,7 @@ static int __init rockchip_grf_init(void)
                grf = syscon_node_to_regmap(np);
                if (IS_ERR(grf)) {
                        pr_err("%s: could not get grf syscon\n", __func__);
+                       of_node_put(np);
                        return PTR_ERR(grf);
                }