]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
pop3-login: proxy - Don't try to reconnect and retry XCLIENT command failures
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Mon, 2 Feb 2026 11:05:09 +0000 (13:05 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Fri, 6 Feb 2026 07:58:43 +0000 (07:58 +0000)
src/pop3-login/pop3-proxy.c

index 68f1c8b1d18c93f1983f58e98fa0cdf669fe186a..d7e88c6769e4d5f967cec9d0142db1a57f82a417 100644 (file)
@@ -253,9 +253,11 @@ int pop3_proxy_parse_line(struct client *client, const char *line)
                if (!str_begins_with(line, "+OK")) {
                        const char *reason = t_strdup_printf(
                                "XCLIENT failed: %s", str_sanitize(line, 160));
+                       /* XCLIENT failure is some misconfiguration - don't try
+                          to reconnect. */
                        login_proxy_failed(client->login_proxy,
                                login_proxy_get_event(client->login_proxy),
-                               LOGIN_PROXY_FAILURE_TYPE_REMOTE, reason);
+                               LOGIN_PROXY_FAILURE_TYPE_REMOTE_CONFIG, reason);
                        return -1;
                }
                pop3_client->proxy_state = client->proxy_sasl_client == NULL ?