Stop including dnstap headers from <dns/dnstap.h>

The <fstrm.h> and <protobuf-c/protobuf-c.h> headers are only directly
included where used and we stopped exposing those headers from libdns
headers.

diff --git a/bin/named/main.c b/bin/named/main.c
index cfdc941e05597a357163607264fa1cc07258ba2d..c8ea183269e91008fdd42682f1da8e4be31ce848 100644 (file)
--- a/bin/named/main.c
+++ b/bin/named/main.c
@@ -18,6 +18,10 @@
 #include <string.h>
 #include <uv.h>
 
+#ifdef HAVE_DNSTAP
+#include <protobuf-c/protobuf-c.h>
+#endif
+
 #include <isc/app.h>
 #include <isc/attributes.h>
 #include <isc/backtrace.h>

diff --git a/bin/named/server.c b/bin/named/server.c
index c2afd5523a0baeedff1fe71bacda0be586f84e00..4659815ffb799d497c041f0adb8e572f4bd9acbc 100644 (file)
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -20,6 +20,10 @@
 #include <sys/types.h>
 #include <unistd.h>
 
+#ifdef HAVE_DNSTAP
+#include <fstrm.h>
+#endif
+
 #include <isc/aes.h>
 #include <isc/app.h>
 #include <isc/attributes.h>

diff --git a/lib/bind9/check.c b/lib/bind9/check.c
index e789aaadd1ca5814cf042f3f4d46260d30287d03..67f2f96642fd5b5ddbab3e2588834ca653312dcb 100644 (file)
--- a/lib/bind9/check.c
+++ b/lib/bind9/check.c
@@ -15,6 +15,10 @@
 #include <stdbool.h>
 #include <stdlib.h>
 
+#ifdef HAVE_DNSTAP
+#include <fstrm.h>
+#endif
+
 #include <isc/aes.h>
 #include <isc/base64.h>
 #include <isc/buffer.h>

diff --git a/lib/dns/dnstap.c b/lib/dns/dnstap.c
index 44fb25e73ce6091d9eda77ff8d3cff2618cd9db2..2688b30a3381392f8846c30b8bfd202edef7ab44 100644 (file)
--- a/lib/dns/dnstap.c
+++ b/lib/dns/dnstap.c
@@ -47,12 +47,11 @@
 #error DNSTAP not configured.
 #endif /* HAVE_DNSTAP */
 
+#include <fstrm.h>
 #include <inttypes.h>
 #include <stdbool.h>
 #include <stdlib.h>
 
-#include <protobuf-c/protobuf-c.h>
-
 #include <isc/buffer.h>
 #include <isc/file.h>
 #include <isc/log.h>

diff --git a/lib/dns/include/dns/dnstap.h b/lib/dns/include/dns/dnstap.h
index 9a13525bf3191368efc351bdb61c6f2db443eb92..14e042c3c61a3cac002875b605090685d655e829 100644 (file)
--- a/lib/dns/include/dns/dnstap.h
+++ b/lib/dns/include/dns/dnstap.h
@@ -26,13 +26,7 @@
 #include <inttypes.h>
 #include <stdbool.h>
 
-#ifdef HAVE_DNSTAP
-#include <fstrm.h>
-
-#include <protobuf-c/protobuf-c.h>
-#else  /* ifdef HAVE_DNSTAP */
 struct fstrm_iothr_options;
-#endif /* HAVE_DNSTAP */
 
 #include <isc/log.h>
 #include <isc/refcount.h>

diff --git a/lib/dns/tests/dnstap_test.c b/lib/dns/tests/dnstap_test.c
index b41cd14fd45d8988ba5c0db10b09b7cc0c32ee8b..5c46eda56d96e6d55ce8d85154d0ff70979dd175 100644 (file)
--- a/lib/dns/tests/dnstap_test.c
+++ b/lib/dns/tests/dnstap_test.c
@@ -37,6 +37,8 @@
 
 #ifdef HAVE_DNSTAP
 
+#include <fstrm.h>
+
 #include <protobuf-c/protobuf-c.h>
 
 #define TAPFILE "testdata/dnstap/dnstap.file"