fix: disable SC2317 for calls by for_each_host_dev_and_slaves

shellcheck 0.10 complains about SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly). It fails to
detect cases where a function is defined and later called by
`for_each_host_dev_and_slaves`. Disable shellcheck in this case.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>

diff --git a/modules.d/90kernel-modules/module-setup.sh b/modules.d/90kernel-modules/module-setup.sh
index 89f332319df1aaa1f2f8c28e4bea9355d68d3f48..444d58a7eefa40830aa8fc3b2c759d19c4c53ee7 100755 (executable)
--- a/modules.d/90kernel-modules/module-setup.sh
+++ b/modules.d/90kernel-modules/module-setup.sh
@@ -5,6 +5,7 @@ installkernel() {
     local _blockfuncs='ahci_platform_get_resources|ata_scsi_ioctl|scsi_add_host|blk_cleanup_queue|register_mtd_blktrans|scsi_esp_register|register_virtio_device|usb_stor_disconnect|mmc_add_host|sdhci_add_host|scsi_add_host_with_dma|blk_alloc_disk|blk_mq_alloc_disk|blk_mq_alloc_request|blk_mq_destroy_queue|blk_cleanup_disk'
     local -A _hostonly_drvs
 
+    # shellcheck disable=SC2317  # called later by for_each_host_dev_and_slaves
     record_block_dev_drv() {
 
         for _mod in $(get_dev_module /dev/block/"$1"); do

diff --git a/modules.d/90multipath/module-setup.sh b/modules.d/90multipath/module-setup.sh
index 5ba534fe3419851ab2dce1d507be181d2a8d7777..a451ef8616dfb465ff6e46397b3b8c930a0f2d31 100755 (executable)
--- a/modules.d/90multipath/module-setup.sh
+++ b/modules.d/90multipath/module-setup.sh
@@ -69,6 +69,7 @@ install() {
     local -A _allow
     local config_dir
 
+    # shellcheck disable=SC2317  # called later by for_each_host_dev_and_slaves
     add_hostonly_mpath_conf() {
         if is_mpath "$1"; then
             local _dev

diff --git a/modules.d/95fcoe-uefi/module-setup.sh b/modules.d/95fcoe-uefi/module-setup.sh
index 9dc1e73388c6069208ce000161f399aa1eb37c83..24acf998afddf08776f0c5a16d37c4392e38231d 100755 (executable)
--- a/modules.d/95fcoe-uefi/module-setup.sh
+++ b/modules.d/95fcoe-uefi/module-setup.sh
@@ -2,6 +2,7 @@
 
 # called by dracut
 check() {
+    # shellcheck disable=SC2317  # called later by for_each_host_dev_and_slaves
     is_fcoe() {
         block_is_fcoe "$1" || return 1
     }

diff --git a/modules.d/95fcoe/module-setup.sh b/modules.d/95fcoe/module-setup.sh
index 3de85c21ed9c2861fc0b7aed0599717d024c3fa7..ecebbda0127912d3bef4363bbde5d7bb3f5dbdfa 100755 (executable)
--- a/modules.d/95fcoe/module-setup.sh
+++ b/modules.d/95fcoe/module-setup.sh
@@ -2,6 +2,7 @@
 
 # called by dracut
 check() {
+    # shellcheck disable=SC2317  # called later by for_each_host_dev_and_slaves
     is_fcoe() {
         block_is_fcoe "$1" || return 1
     }

diff --git a/modules.d/95iscsi/module-setup.sh b/modules.d/95iscsi/module-setup.sh
index bec6e8f4dd90696f56ec5e32fa5a9cc09ced3def..d3307b98b82811c217c2af572af90b0be1fdac9b 100755 (executable)
--- a/modules.d/95iscsi/module-setup.sh
+++ b/modules.d/95iscsi/module-setup.sh
@@ -134,6 +134,7 @@ install_iscsiroot() {
 install_softiscsi() {
     [ -d /sys/firmware/ibft ] && return 0
 
+    # shellcheck disable=SC2317  # called later by for_each_host_dev_and_slaves
     is_softiscsi() {
         local _dev=$1
         local iscsi_dev

diff --git a/modules.d/95lunmask/module-setup.sh b/modules.d/95lunmask/module-setup.sh
index cf6e3d7ef57953b91dfcf5e6c94b7a32bfbf247a..f78cb268ff3fc5d4cf3123939584869b2e30343f 100755 (executable)
--- a/modules.d/95lunmask/module-setup.sh
+++ b/modules.d/95lunmask/module-setup.sh
@@ -4,6 +4,7 @@
 
 # called by dracut
 cmdline() {
+    # shellcheck disable=SC2317  # called later by for_each_host_dev_and_slaves
     get_lunmask() {
         local _dev=$1
         local _devpath _sdev _lun _rport _end_device _classdev _wwpn _sas_address

diff --git a/modules.d/95nvmf/module-setup.sh b/modules.d/95nvmf/module-setup.sh
index 6a1e3f5bcb336c2e3791698fa131bc82790a2efc..c2cf0fb7bcd1c67b0469579fbcb53e287b25f68a 100755 (executable)
--- a/modules.d/95nvmf/module-setup.sh
+++ b/modules.d/95nvmf/module-setup.sh
@@ -4,6 +4,7 @@
 check() {
     require_binaries nvme jq || return 1
 
+    # shellcheck disable=SC2317  # called later by for_each_host_dev_and_slaves
     is_nvmf() {
         local _dev=$1
         local trtype
@@ -68,6 +69,7 @@ cmdline() {
     local _hostnqn
     local _hostid
 
+    # shellcheck disable=SC2317  # called later by for_each_host_dev_and_slaves
     gen_nvmf_cmdline() {
         local _dev=$1
         local trtype