]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: samsung: exynos4-is: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 9 Jan 2026 16:57:56 +0000 (17:57 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 16 Mar 2026 10:51:55 +0000 (11:51 +0100)
Use scoped for_each_compatible_node_scoped() loop when iterating over
device nodes to make code a bit simpler.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/samsung/exynos4-is/fimc-is.c

index 14d84cc96831ca77f8699344a61d17d7872bd44b..b7d9bfedd590fae35fcdbc7dd7beeaebb71010f8 100644 (file)
@@ -200,21 +200,19 @@ static int fimc_is_parse_sensor_config(struct fimc_is *is, unsigned int index,
 
 static int fimc_is_register_subdevs(struct fimc_is *is)
 {
-       struct device_node *i2c_bus;
        int ret, index = 0;
 
        ret = fimc_isp_subdev_create(&is->isp);
        if (ret < 0)
                return ret;
 
-       for_each_compatible_node(i2c_bus, NULL, "samsung,exynos4212-i2c-isp") {
+       for_each_compatible_node_scoped(i2c_bus, NULL, "samsung,exynos4212-i2c-isp") {
                for_each_available_child_of_node_scoped(i2c_bus, child) {
                        ret = fimc_is_parse_sensor_config(is, index, child);
 
-                       if (ret < 0 || index >= FIMC_IS_SENSORS_NUM) {
-                               of_node_put(i2c_bus);
+                       if (ret < 0 || index >= FIMC_IS_SENSORS_NUM)
                                return ret;
-                       }
+
                        index++;
                }
        }