]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
Fix maybe-uninitialized warnings with gcc 14.2
authorLuca Boccassi <luca.boccassi@gmail.com>
Wed, 16 Oct 2024 10:42:06 +0000 (11:42 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Wed, 13 Nov 2024 19:48:10 +0000 (19:48 +0000)
../src/resolve/resolved-bus.c: In function ‘call_link_method’:
../src/resolve/resolved-bus.c:1769:16: warning: ‘l’ may be used uninitialized [-Wmaybe-uninitialized]
 1769 |         return handler(message, l, error);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
../src/resolve/resolved-bus.c:1755:15: note: ‘l’ was declared here
 1755 |         Link *l;
      |               ^
../src/resolve/resolved-bus.c: In function ‘bus_method_get_link’:
../src/resolve/resolved-bus.c:1828:13: warning: ‘l’ may be used uninitialized [-Wmaybe-uninitialized]
 1828 |         p = link_bus_path(l);
      |             ^~~~~~~~~~~~~~~~
../src/resolve/resolved-bus.c:1816:15: note: ‘l’ was declared here
 1816 |         Link *l;
      |               ^

(cherry picked from commit 5f911aca8434b4163514019fcb4c1c967a50617c)

src/resolve/resolved-bus.c

index 847bb6bc6ec43cafe12d8ebb121058ab95d38077..0b9324ca8c6598f3b9e4a3b554555d6f62927caf 100644 (file)
@@ -1752,7 +1752,7 @@ static int get_any_link(Manager *m, int ifindex, Link **ret, sd_bus_error *error
 
 static int call_link_method(Manager *m, sd_bus_message *message, sd_bus_message_handler_t handler, sd_bus_error *error) {
         int ifindex, r;
-        Link *l;
+        Link *l = NULL;  /* avoid false maybe-uninitialized warning */
 
         assert(m);
         assert(message);
@@ -1813,7 +1813,7 @@ static int bus_method_get_link(sd_bus_message *message, void *userdata, sd_bus_e
         _cleanup_free_ char *p = NULL;
         Manager *m = ASSERT_PTR(userdata);
         int r, ifindex;
-        Link *l;
+        Link *l = NULL;  /* avoid false maybe-uninitialized warning */
 
         assert(message);