]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-sql: driver-sqlite - Use ctx->error in driver_sqlite_transaction_commit_s()
authorAki Tuomi <aki.tuomi@open-xchange.com>
Wed, 26 Nov 2025 11:09:46 +0000 (13:09 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Thu, 29 Jan 2026 16:45:30 +0000 (16:45 +0000)
Logging error_r too soon will just crash.

src/lib-sql/driver-sqlite.c

index 1fb339832a9a98c129757a14684d320ac41c037b..3cb9e5bb9ce98a3af664cb74766be62b521d3d3e 100644 (file)
@@ -715,8 +715,8 @@ driver_sqlite_transaction_commit_s(struct sql_transaction_context *_ctx,
        driver_sqlite_transaction_exec(ctx, "COMMIT");
        if (!SQLITE_IS_OK(ctx->rc)) {
                e_debug(sql_transaction_finished_event(_ctx)->
-                       add_str("error", *error_r)->event(),
-                       "Transaction failed");
+                       add_str("error", ctx->error)->event(),
+                       "Transaction failed: %s", ctx->error);
                *error_r = t_strdup(ctx->error);
                driver_sqlite_transaction_rollback(_ctx);
                return -1;