Revert "ALSA: pcmtest: fix reference leak on failed device registration"

We'd like to address the problem rather in the error code path of
platform_device_register() itself instead of leaving it all callers,
since less than 1% of all callers of over 100
platform_device_register() do call platform_device_put() properly as
of now.

For making the work easier, revert the previous change commit
4ff036f95238 ("ALSA: pcmtest: fix reference leak on failed device
registration") again.

Link: https://lore.kernel.org/20260415193138.3861297-1-lgs201920130244@gmail.com
Link: https://patch.msgid.link/20260423075211.3977366-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c
index fe31ff1e5b3c3cb8f0f9f1b8cb188843adebf523..5bfec4c7bf7147538749ad8169ee952ea9df595e 100644 (file)
--- a/sound/drivers/pcmtest.c
+++ b/sound/drivers/pcmtest.c
@@ -756,10 +756,8 @@ static int __init mod_init(void)
        if (err)
                goto err_free_patterns;
        err = platform_device_register(&pcmtst_pdev);
-       if (err) {
-               platform_device_put(&pcmtst_pdev);
+       if (err)
                goto err_clear_debug;
-       }
        err = platform_driver_register(&pcmtst_pdrv);
        if (err) {
                platform_device_unregister(&pcmtst_pdev);